Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changing ~/.ssh/config is a bad idea, sometimes this isn't managed manually #3

Closed
cnf opened this issue May 15, 2017 · 4 comments
Closed

Comments

@cnf
Copy link

cnf commented May 15, 2017

I use assh which manages my ~/.ssh/config. There are other situations where the ssh_config isn't manually managed.

Editing the ssh_config without user consent at best doesn't work, and at worse breaks the users ssh setup.

Please don't do this... echo what to do or make a command to do it, but don't do this without asking for it.

@jbgosselin
Copy link

I totally agree, I love your product but I removed it just because I don't want re-do my ssh config every-time it is updated.

@halostatue
Copy link

This should be fixable with a post-message and/or a “build-time” option (--no-ssh-config) so that those of us who manage your SSH configurations can force reconfiguration based on the new settings (I have things set up to handle this correctly).

@kcking
Copy link
Contributor

kcking commented May 23, 2017

Sorry for the incompatibility with assh. As a stopgap fix, I added a --without-ssh-config option which will not run any commands to modify ~/.ssh/config and prints what should be added there in the caveats.

We might move ssh_config logic to kr pair and prompt the user then

@kcking
Copy link
Contributor

kcking commented Aug 9, 2017

Our latest update moves SSH configuration to the kr pair stage instead of installation time. This solves the issue of SSH not being configured for other usernames on the computer. We added an env var to prevent kr from touching your ssh config, export KR_SKIP_SSH_CONFIG=1. Note that the config file is always backed up in the same directory before we modify it.

@kcking kcking closed this as completed Aug 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants