Translate build and test workflow to Kotlin DSL #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krzema12
force-pushed
the
translate-build-and-test-workflow-to-Kotlin-DSL
branch
from
b04984e
to
5293ea3
Compare
krzema12
force-pushed
the
translate-build-and-test-workflow-to-Kotlin-DSL
branch
from
5293ea3
to
cad2502
Compare
SerVB
approved these changes
Jan 26, 2022
There was a problem hiding this comment.
And what about another workflow file?
My though regarding deduplication was quite opposite: merge to the single file. However, that would include some error-prone conditions based on the file input (like workflow_dispatch or push). You way is better that we can have linear workflows. And I generally love the DSL :)
Comment on lines
+91
to
+96
| run: | | ||
| python/experiments/generate-box-tests-reports.main.kts \ | ||
| --test-task=${{ matrix.testTask }} \ | ||
| --failed-tests-report-path=failed-tests.txt \ | ||
| --box-tests-report-path=box-tests-report.tsv \ | ||
| --failure-count-report-path=failure-count.tsv |
There was a problem hiding this comment.
Well, I was OK with long lines ;)
There was a problem hiding this comment.
I actually found them hard to work with. Horizontal scrolling is painful :)
I'll tackle it in a separate PR, will experiment with having both in one file VS separated :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of typesafegithub/github-workflows-kt#3.
The workflows in kotlin-python are the main inspiration to me to create https://github.com/krzema12/github-actions-kotlin-dsl/.
That's why I'd like to use it in this project, so that we have a real-life scenario and "customer zero".
I'm migrating just one workflow as an experiment, and once it's merged, I'll do the same with the other one. By having them in the same Kotlin file or sharing common Kotlin file, we'll manage to remove some across-workflows duplication.
Testing
I compared workflows in runtime, before and after this change:
pythonTest: before and aftermicroPythonTest: before and afterI also checked how it works in case of forgetting to regenerate the YAML. It now fails at runtime:
and in the future we can e.g. add auto-generated job that regenerates the YAML. The golden grail is GitHub supporting such Kotlin DSL, without any (semi)manual generation steps.