Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: v1 metrics schema with scope metrics #52

Merged
merged 2 commits into from
Oct 6, 2022
Merged

fix: v1 metrics schema with scope metrics #52

merged 2 commits into from
Oct 6, 2022

Conversation

bbortt
Copy link
Contributor

@bbortt bbortt commented Oct 5, 2022

instrumentationLibraryMetrics is not compatible with the provided resourceMetrics type. it should actually be scopeMetrics instead.

I've noticed it because the open-telemetry collector returned the HTTP 500 code, saying that "the key resourceMetrics[0].instrumentationLibraryMetrics is invalid". the shell extension does manage to send metrics to the collector with this schema.

@bbortt bbortt requested a review from krzko as a code owner October 5, 2022 17:15
krzko
krzko approved these changes Oct 6, 2022
View reviewed changes
Copy link
Owner

@krzko krzko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch on this one, thank you very much for contributing 🚀

@krzko krzko merged commit ef7cbcf into krzko:main Oct 6, 2022
@bbortt bbortt deleted the bugfix/v1-metrics-schema branch October 6, 2022 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krzko krzko krzko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bbortt @krzko