Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn/error if in keyword used #440

Closed
originalfoo opened this issue Jul 19, 2019 · 2 comments · Fixed by #463
Closed

Warn/error if in keyword used #440

originalfoo opened this issue Jul 19, 2019 · 2 comments · Fixed by #463
Labels
code cleanup Refactor code, remove old code, improve maintainability performance Make it faster! technical Tasks that need to be performed in order to improve quality and maintainability
Milestone
11.0

Comments

@originalfoo
Copy link
Member

originalfoo commented Jul 19, 2019 •
edited

As per Dymanoid's comment - #349 (comment) - we should avoid using in.

Rule of thumb: don't use in. If you still want to use it, see rule of thumb. Please read this SO question and the two most upvoted answers.

Would be good if we could get Rosyln analyser (or whatever) to complain if in is used anywhere (if it doesn't already do this, not checked).
@originalfoo originalfoo added technical Tasks that need to be performed in order to improve quality and maintainability code cleanup Refactor code, remove old code, improve maintainability performance Make it faster! labels Jul 19, 2019
@dymanoid
Copy link
Contributor

I could drop in a PR for this one.

@originalfoo
Copy link
Member Author

👍

@dymanoid dymanoid mentioned this issue Jul 26, 2019
Merged
@originalfoo originalfoo added this to the 11.0 milestone Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code cleanup Refactor code, remove old code, improve maintainability performance Make it faster! technical Tasks that need to be performed in order to improve quality and maintainability
Projects
None yet
Milestone
11.0
Development

Successfully merging a pull request may close this issue.

Prevent usage of 'in' with non-readonly structs by a compiler error
2 participants
@originalfoo @dymanoid