zerocracy#559 CR

krzyk · Jul 11, 2018 · 0ebbb50 · 0ebbb50
1 parent f62c74c
commit 0ebbb50
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 5 deletions.
diff --git a/src/main/java/com/zerocracy/pmo/People.java b/src/main/java/com/zerocracy/pmo/People.java
@@ -850,18 +850,18 @@ public Date appliedTime(final String uid) throws IOException {
 
     /**
      * Skills of a person.
-     * @param uid Person's login
+     * @param user Person's login
      * @return Iterable with skills
      * @throws IOException If fails
      */
-    public Iterable<String> skills(final String uid) throws IOException {
+    public Iterable<String> skills(final String user) throws IOException {
         try (final Item item = this.item()) {
             return new Mapped<>(
                 xml -> xml.node().getTextContent(),
                 new Xocument(item.path()).nodes(
                     String.format(
                         "/people/person[@id = '%s']/skills/skill",
-                        uid
+                        user
                     )
                 )
             );

diff --git a/src/test/java/com/zerocracy/pmo/PeopleTest.java b/src/test/java/com/zerocracy/pmo/PeopleTest.java
@@ -558,8 +558,9 @@ public void setsLinks() throws Exception {
 
     @Test
     public void setsSkills() throws IOException {
-        final People people =
-            new People(new FkFarm(new FkProject())).bootstrap();
+        final People people = new People(
+            new FkFarm(new FkProject())
+        ).bootstrap();
         final String uid = "user";
         people.invite(uid, "0crat");
         final Iterable<String> skills = new IterableOf<>("c", "cobol");
@@ -570,6 +571,19 @@ public void setsSkills() throws IOException {
         );
     }
 
+    @Test
+    public void getsEmptySkillList() throws IOException {
+        final People people = new People(
+            new FkFarm(new FkProject())
+        ).bootstrap();
+        final String uid = "user";
+        people.invite(uid, "0crat");
+        MatcherAssert.assertThat(
+            people.skills(uid),
+            Matchers.emptyIterable()
+        );
+    }
+
     private void failsWallet(final String bank, final String wallet)
         throws IOException {
         final FkFarm farm = new FkFarm(new FkProject());