Add support for tickRotor plugin #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of Flot 0.8.3, the tickRotor plugin has to move the tick labels from opts.ticks to opts.rotatedTicks to avoid a bug. For tooltips, this means that any content that uses the %y value won't work. Hence, in this commit we check for use of tickRotor and lookup 'ticks' vs 'rotatedTicks' in the xaxis object as appropriate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of Flot 0.8.3, the tickRotor plugin has to move the tick labels from
opts.ticks to opts.rotatedTicks to avoid a bug. For tooltips, this means
that any content that uses the %y value won't work. Hence, in this
commit we check for use of tickRotor and lookup 'ticks' vs
'rotatedTicks' in the xaxis object as appropriate.
I see in other PRs there's an attempt to standardize how to lookup a plugin, but as they weren't merged I just looked it up via $.plot.plugins