Responsive design with VUE #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 24, 2019 11:45
Adding respoinsive tags and style issues
Font changes
krzysztofrewak
requested changes
Oct 25, 2019
Did the asked revisions Only issue is I dont understand what you mean by vertical density? I checked the file and compared with master the only time I affect it is when changing your margins a bit on line 44 and 49 everything looks the same as in master branch as for the 3 scroll jumps I removed them, but it was an strange quirk of the fix I did for your mobile jump issue I mentioned one scroll didnt seem to fix it but 3 seemed to do the trick I think is still the page builder executing , and moving scroll all the way to end. if you find any issues let me know
|
Hey I sent you some comments, the only issue I have is about the vertical density Since I don't see it on comparison files both on notepad ++ and the comparison file on my end I can send you screenshots |
vertical density changes found
|
I corrected all issues Hope this is for your liking let me know of any issues you may find |
|
@cagomezr, thanks for your help! I merged your changes into master, it should be visible on https://krzysztofrewak.github.io/bjcp-ui/ soon. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good day !
I enabled responsive design and did some stylistic choices on your program(mostly organization on mobile range.
I added a quick fix that will allow your program to not throw scroll around as you rebuild the "flex tables " I'm not sure how Vue.JS does it, entirely (I have read superficially for this project and a few interviews) but I think you are rebuilding tables more than once every time you do a click event and henceforth throwing the scroll as it is rebuilding the flex tables again and moving scroll to last element at bottom to table. I added scroll to top to try to fix the issue, but I realize this may not be the most elegant solution to this problem,-nor correct one but didnt want to change your code without asking first or more research into problem
If you have any questions or feedback I can help you with this further #1