Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LifetimeTracker framework cannot be build on Xcode 9 / 9.1 #23

Closed
huy-le opened this issue Nov 8, 2017 · 5 comments
Closed

LifetimeTracker framework cannot be build on Xcode 9 / 9.1 #23

huy-le opened this issue Nov 8, 2017 · 5 comments
Labels
bug

Comments

@huy-le
Copy link

huy-le commented Nov 8, 2017

I used Carthage to build this framework, but it failed. Then I tried to use Xcode to build the cloning from Carthage, it still failed.

I clone the v1.2 as well as master and try to build on Xcode 9/9.1. All failed by same errors. It is missing Constants type.

See attachments.

screen shot 2017-11-09 at 10 37 20 am
@krzysztofzablocki
Copy link
Owner

@tschob did we forget to include the file in pbxproj?

@tschob tschob added the bug label Nov 10, 2017
@tschob
Copy link
Collaborator

tschob commented Nov 10, 2017

@krzysztofzablocki Yes. I used the Example project to modify the library. Therefore the classes which I added aren't in the actual Xcode project. I have added them now and also added the actual Xcode project to the Example workspace. I also fixed the UIKit usage for non iOS targets.

The Carthage usage should work now again.

@huy-le The branch "issue/#23" should fix the build errors. You might have to clean your current checkout in the Carthage folder if it complains about "LifetimeTracker.xcodeproj cannot be opened because it is missing its project". The fix is part of pull request #24

@huy-le
Copy link
Author

huy-le commented Nov 10, 2017

Thanks, will try it!

@huy-le huy-le closed this as completed Nov 10, 2017
@tschob
Copy link
Collaborator

tschob commented Nov 10, 2017

@huy-le You are welcome. Did it solve the issue for you?

krzysztofzablocki pushed a commit that referenced this issue Nov 11, 2017
@tschob @krzysztofzablocki
Fixes #23 (#24)
1eea985 
* [Example] Update LifetimeTracker Pod version

* Add missing files to the library Xcode project and remove UIKit usage from non iOS targets

* Remove UIKit Dependency from localized Strings helper

* Remove UIKit dependency from Constants file

* [Example] Update LifetimeTracker Pod version

* [Example] Rename Example project to "Example" to avoid confusion to the actual LifetimeTracker project

* [Example] Add actual LifetimeTracker Xcode project to workspace to enable the editing of the library
@huy-le
Copy link
Author

huy-le commented Nov 12, 2017

@tschob Yes, it did 👍 Thanks for prompt response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@krzysztofzablocki @tschob @huy-le