Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 0.10.0: Unknown filter 'replace' #458

Closed
Lutzifer opened this issue Dec 14, 2017 · 22 comments
Closed

Version 0.10.0: Unknown filter 'replace' #458

Lutzifer opened this issue Dec 14, 2017 · 22 comments

Comments

@Lutzifer
Copy link
Contributor

I can no longer use the replace filter since 0.10.0

Was it removed accidentally?

@rymcol
Copy link

rymcol commented Dec 14, 2017

Same for 'hasPrefix'

@rymcol
Copy link

rymcol commented Dec 14, 2017

If you're affected by this and using homebrew you can always brew switch sourcery 0.9.0 temporarily until there is a fix presuming 0.9.0 was installed previously.

@Lutzifer
Copy link
Contributor Author

I will have a deeper look at that tomorrow

@krzysztofzablocki
Copy link
Owner

@Antondomashnev any idea why that would happen ?

@Lutzifer
Copy link
Contributor Author

it does work, if I call sourcery from Xcode and add the arguments in the scheme, but not if installed via mint or brew

@Antondomashnev
Copy link
Collaborator

@krzysztofzablocki @Lutzifer not sure what happened. If @Lutzifer will not be able to find a reason I will try to check on the weekend.

@natanrolnik
Copy link

Same happening here with contains. Let me know if there is more info I can provide. Sourcery 0.10.0.

@Lutzifer
Copy link
Contributor Author

Seems to me as if the SwiftPM build is resolving quite an old Version of StencilSwiftKit:

Resolving https://github.com/SwiftGen/StencilSwiftKit.git at 1.0.2

@Antondomashnev might this be the cause?

@Antondomashnev
Copy link
Collaborator

@Lutzifer that looks like the source of the problem, yep. I can force update the 0.10.0 with the correct SPM dependencies most likely later tonight.

@Antondomashnev
Copy link
Collaborator

Update: sorry for the delay, I've been sick past days. Will try to release today.

@Lutzifer
Copy link
Contributor Author

changing the versions as in https://github.com/Lutzifer/Sourcery/tree/fix_versions did it for me.

Also, we should update version to 0.10.1 instead of doing a force update.

@Antondomashnev
Copy link
Collaborator

@Lutzifer I was planning to do a new version since we have some new things to share already.

@Antondomashnev
Copy link
Collaborator

The release is done. Could please somebody checks 😄

@Lutzifer
Copy link
Contributor Author

@Antondomashnev works when installed using mint

@Mazyod
Copy link

Mazyod commented Jan 3, 2018

I don't think it was fixed for homebrew users. I updated today, and ran into the same problem.

@jpsim
Copy link
Contributor

jpsim commented Jan 4, 2018

Correct, the homebrew version wasn't updated

@Antondomashnev
Copy link
Collaborator

Will have a look, thanks for reporting it.

@Antondomashnev Antondomashnev reopened this Jan 4, 2018
@Antondomashnev
Copy link
Collaborator

Antondomashnev commented Jan 4, 2018

@jpsim @Mazyod the PR in brew has not been merged yet. Once it's approved, the new version should be available.

@klundberg
Copy link
Contributor

PR was merged just a little while ago, thankfully :). Looks like this can be closed

@Mazyod
Copy link

Mazyod commented Jan 17, 2018

Still can't seem to make it work:

if which sourcery >/dev/null; then
  sourcery --version
  sourcery --config sourcery/objc-access.sourcery.yml
else
  echo "warning: Sourcery not installed"
  echo "brew install sourcery"
fi
0.10.1
Using configuration file at 'sourcery/objc-access.sourcery.yml'. WARNING: Ignoring the parameters passed in the command line.
Scanning sources...
Found 326 types.
Loading templates...
Loaded 1 templates.
Generating code...
error: [...]/sourcery/Templates/ObjCBridge.stencil: Unknown filter 'lowerFirst'

@krzysztofzablocki
Copy link
Owner

@Mazyod lowerFirstWord or lowerFirstLetter, take a look at https://github.com/SwiftGen/StencilSwiftKit

@Antondomashnev
Copy link
Collaborator

@krzysztofzablocki I think the error @Mazyod once again brought us to the idea in #471.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants