Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using our own fork of Stencil #567

Closed
ilyapuchka opened this issue Mar 29, 2018 · 6 comments
Closed

Using our own fork of Stencil #567

ilyapuchka opened this issue Mar 29, 2018 · 6 comments

Comments

@ilyapuchka
Copy link
Collaborator

If we want to evolve Stencil templates to make using them with Sourcery (and SwiftGen) a less frustrating experience I suggest to switch to our own fork of Stencil. There are a lot of pull request with, in my opinion, valuable improvements, which are not moving anywhere already for few months, including white spaces control and various other cool features.

As we are using StencilSwiftKit it should be probably done on their side first. Or we can just include all its additional nodes and filters in this fork and drop StencilSwiftKit.

@krzysztofzablocki @AliSoftware what do you think?

@krzysztofzablocki
Copy link
Owner

I agree, kyle seems too busy and we shouldn't be blocked by that, Sourcery and SwiftGen are both used by much wider audience than Stencil itself afaik

@AliSoftware
Copy link
Contributor

I agree that there are a lot of valuable improvements for Stencil that are pending. But I'm not sure having a fork is the right solution, because it could also diverge quite quickly (and users would then have to refer to different docs depending on if they are writing Stencil templates for the main Stencil or for our fork, because some tags will exist in one place but not the other…).

I think it would be better if @kylef would agree to give us Push access to Stencil so we can help him maintain it ?

@AliSoftware
Copy link
Contributor

btw I'm not sure if both of you have push access to StencilSwiftKit, if that's not the case don't hesitate to ask, I'll gladly give it to you.

@ilyapuchka
Copy link
Collaborator Author

I have push access to Stencil, but Sourcery and SwiftGen specifics require Stencil to be more dynamic, because final user has no control of context, than it may be needed for web frameworks where context is fully under control of user, so I think fork would be better.

@AliSoftware
Copy link
Contributor

Ok seems like @yonaskolb would be interested in a fork too, for SwagGen and Genesis… so let's do this.

I'm gonna try and make a release of StencilSwiftKit tomorrow evening, then we could start forking and even make the fork absorb StencilSwiftKit to merge the two together.

@ilyapuchka
Copy link
Collaborator Author

I've tried to update references to Stencil with new location, but it fails for SPM, I guess it is blocked by SwiftGen/StencilSwiftKit#88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants