Update SwiftSyntax dependency to 510.0.0 #1294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @calda , firstly, welcome to The Contributors club 🤝 🥳 🎈 🎉 secondly, thank you so much for tackling this! I have had this in mind, but postponed it until after 2.1.8 release. CI passed, so this PR is verified by more than 600 tests, in actuality there are much more unit tests within those 600+ behavioural tests. Merging 🎉 |
art-divin
added a commit
that referenced
this pull request
Mar 10, 2024
commit 5e6df69 Author: Ruslan Alikhamov <r.alikhamov@gmail.com> Date: Sun Mar 10 11:53:37 2024 +0400 Resolved all SwiftSyntax Warnings (#1295) * Resolved all swiftSyntax warnings * Set concrete Ubuntu version to fix GH action * Switch to another GH action commit 864505a Author: Cal Stephens <cal@calstephens.tech> Date: Thu Mar 7 23:10:56 2024 -0800 Update SwiftSyntax dependency to 510.0.0 (#1294) * Update to SwiftSyntax for Swift 5.10 * Patch build
art-divin
added a commit
that referenced
this pull request
Mar 10, 2024
* Refactoring * Squashed commit of the following: commit 864505a Author: Cal Stephens <cal@calstephens.tech> Date: Thu Mar 7 23:10:56 2024 -0800 Update SwiftSyntax dependency to 510.0.0 (#1294) * Update to SwiftSyntax for Swift 5.10 * Patch build * Fixed build error * Removed TODO * Adding new annotation parsing method * Squashed commit of the following: commit 5e6df69 Author: Ruslan Alikhamov <r.alikhamov@gmail.com> Date: Sun Mar 10 11:53:37 2024 +0400 Resolved all SwiftSyntax Warnings (#1295) * Resolved all swiftSyntax warnings * Set concrete Ubuntu version to fix GH action * Switch to another GH action commit 864505a Author: Cal Stephens <cal@calstephens.tech> Date: Thu Mar 7 23:10:56 2024 -0800 Update SwiftSyntax dependency to 510.0.0 (#1294) * Update to SwiftSyntax for Swift 5.10 * Patch build * Fixed incorrect parsing of annotations in trailing trivia * Removed redundant file * Removed redundant method * Reverted redundant changes
calda
added a commit
to calda/Sourcery
that referenced
this pull request
Mar 11, 2024
* Update to SwiftSyntax for Swift 5.10 * Patch build
calda
added a commit
to calda/Sourcery
that referenced
this pull request
Mar 11, 2024
* Update to SwiftSyntax for Swift 5.10 * Patch build
To close the loop on this, I confirmed that updating to a build of Sourcery that includes this change fixes the parsing issue we were encountering. |
art-divin
pushed a commit
that referenced
this pull request
Mar 17, 2024
* Update to SwiftSyntax for Swift 5.10 * Patch build
art-divin
added a commit
that referenced
this pull request
Mar 17, 2024
* Refactoring * Squashed commit of the following: commit 864505a Author: Cal Stephens <cal@calstephens.tech> Date: Thu Mar 7 23:10:56 2024 -0800 Update SwiftSyntax dependency to 510.0.0 (#1294) * Update to SwiftSyntax for Swift 5.10 * Patch build * Fixed build error * Removed TODO * Adding new annotation parsing method * Squashed commit of the following: commit 5e6df69 Author: Ruslan Alikhamov <r.alikhamov@gmail.com> Date: Sun Mar 10 11:53:37 2024 +0400 Resolved all SwiftSyntax Warnings (#1295) * Resolved all swiftSyntax warnings * Set concrete Ubuntu version to fix GH action * Switch to another GH action commit 864505a Author: Cal Stephens <cal@calstephens.tech> Date: Thu Mar 7 23:10:56 2024 -0800 Update SwiftSyntax dependency to 510.0.0 (#1294) * Update to SwiftSyntax for Swift 5.10 * Patch build * Fixed incorrect parsing of annotations in trailing trivia * Removed redundant file * Removed redundant method * Reverted redundant changes
art-divin
pushed a commit
that referenced
this pull request
Mar 17, 2024
* Update to SwiftSyntax for Swift 5.10 * Patch build
art-divin
added a commit
that referenced
this pull request
Mar 17, 2024
* Refactoring * Squashed commit of the following: commit 864505a Author: Cal Stephens <cal@calstephens.tech> Date: Thu Mar 7 23:10:56 2024 -0800 Update SwiftSyntax dependency to 510.0.0 (#1294) * Update to SwiftSyntax for Swift 5.10 * Patch build * Fixed build error * Removed TODO * Adding new annotation parsing method * Squashed commit of the following: commit 5e6df69 Author: Ruslan Alikhamov <r.alikhamov@gmail.com> Date: Sun Mar 10 11:53:37 2024 +0400 Resolved all SwiftSyntax Warnings (#1295) * Resolved all swiftSyntax warnings * Set concrete Ubuntu version to fix GH action * Switch to another GH action commit 864505a Author: Cal Stephens <cal@calstephens.tech> Date: Thu Mar 7 23:10:56 2024 -0800 Update SwiftSyntax dependency to 510.0.0 (#1294) * Update to SwiftSyntax for Swift 5.10 * Patch build * Fixed incorrect parsing of annotations in trailing trivia * Removed redundant file * Removed redundant method * Reverted redundant changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the SwiftSyntax dependency from 508.0.1 to 510.0.0. This should add support for parsing syntax that was added in Swift 5.9 / Swift 5.10.
For example, within Airbnb we've sometimes seen parsing failures in Sourcery when trying to use if / switch expressions. These were added in Swift 5.9 so are not supported by SwiftSyntax 508.0.1. I believe updating to a more recent version of SwiftSyntax should fix this issue.
SwiftSyntax 509.0.0 included a lot of breaking changes. This PR fixes all the breaking changes, so everything compiles.
As far as I can tell locally, the tests still pass after these changes.