Add isGeneric support #39
Conversation
| return "\(parentName).\(localName)" | ||
| } | ||
|
|
||
| /// Is this type generic? regardless whether it's this type directly or one of its parent types | ||
| var isGeneric: Bool { | ||
| return (parent?.isGeneric ?? false) || hasGenericComponent |
There was a problem hiding this comment.
Do we really need to check parent here? As far as I know generic types can not contain other types, only the other way around.
There was a problem hiding this comment.
Before Swift 3 they couldn't, now they can
There was a problem hiding this comment.
Really? 😯 I get a compilation error with this code:
struct MyStruct<Element> {
struct Inner { } //Type 'Inner' can not be nested in generic type 'MyStruct'
}
There was a problem hiding this comment.
Uh my bad then, it was supposed to happen and I thought it was for Swift 3, I guess it's not ready yet though ;[, quote from them:
"It's an implementation limitation. We'll remove the restriction once our compiler and runtime are able to correctly handle types nested in generic contexts."
There was a problem hiding this comment.
Do you think we should remove this check to improve performance, or doesn't matter?
There was a problem hiding this comment.
For me it is more about confusion between isGeneric and hasGenericComponent as Swift does not currently support that and who knows when it will.
There was a problem hiding this comment.
ok, I'll get rid of it for now 👍
| @@ -456,6 +457,11 @@ extension Parser { | |||
| return annotations | |||
| } | |||
|
|
|||
| fileprivate func isGeneric(source: [String: SourceKitRepresentable]) -> Bool { | |||
| guard let substring = extract(.nameSuffix, from: source), substring.trimmingCharacters(in: .whitespacesAndNewlines).hasPrefix("<") == true else { return false } | |||
There was a problem hiding this comment.
I think there is no need to trim whitespaces as SourceKitten provides offset and tokens length not including spaces. But I might be wrong.
There was a problem hiding this comment.
The problem is that it's not part of scanned things by source kitten, so I'm recognising it by hand from the source code
@ilyapuchka Since you have been so helpful, I've invited you to the project as a collaborator, hope that's ok :)
Check this PR out
Closes #6