Merge pull request #167 from palmin/master

use autorelease pool during PGPS2K iteration to reduce peak memory usage
krzyzanowskim · Nov 30, 2019 · 0867be8 · 0867be8
2 parents afcaf46 + 1423126
commit 0867be8
Showing 1 changed file with 10 additions and 8 deletions.
diff --git a/ObjectivePGP/PGPS2K.m b/ObjectivePGP/PGPS2K.m
@@ -146,15 +146,17 @@ - (nullable NSData *)buildKeyDataForPassphrase:(NSData *)passphrase prefix:(null
                 // then iterate
                 int iterations = 0;
                 while (iterations * data.length < codedCount) {
-                    let nextTotalLength = (iterations + 1) * data.length;
-                    if (nextTotalLength > codedCount) {
-                        let totalLength = iterations * data.length;
-                        let remainder = [data subdataWithRange:(NSRange){0, codedCount - totalLength}];
-                        update(remainder.bytes, (int)remainder.length);
-                    } else {
-                        update(data.bytes, (int)data.length);
+                    @autoreleasepool {
+                        let nextTotalLength = (iterations + 1) * data.length;
+                        if (nextTotalLength > codedCount) {
+                            let totalLength = iterations * data.length;
+                            let remainder = [data subdataWithRange:(NSRange){0, codedCount - totalLength}];
+                            update(remainder.bytes, (int)remainder.length);
+                        } else {
+                            update(data.bytes, (int)data.length);
+                        }
+                        iterations++;
                     }
-                    iterations++;
                 }
             };
         } break;