Lagt til klientMeldingId #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exoen
reviewed
Feb 3, 2022
| @@ -10,6 +10,7 @@ public static SendtMelding FromSentMessageApiModel(SendtMeldingApiModel sendtMel | |||
| { | |||
| return new SendtMelding( | |||
| sendtMeldingApiModel.MeldingId, | |||
| sendtMeldingApiModel.KlientMeldingID, | |||
There was a problem hiding this comment.
De andre suffix er pascalcase på id
exoen
approved these changes
Feb 3, 2022
exoen
approved these changes
Feb 8, 2022
KS.Fiks.IO.Client/Send/SvarSender.cs
Outdated
| @@ -1,6 +1,7 @@ | |||
| using System; | |||
| using System.Collections.Generic; | |||
| using System.IO; | |||
| using System.Security.Cryptography.X509Certificates; | |||
zapodot
approved these changes
Feb 9, 2022
| model.SvarPaMelding == request.SvarPaMelding && | ||
| model.AvsenderKontoId == request.AvsenderKontoId && | ||
| model.MottakerKontoId == request.MottakerKontoId && | ||
| !model.Headere.ContainsKey("klientMeldingId")), |
There was a problem hiding this comment.
Bruk konstant i stedet for String litteral
There was a problem hiding this comment.
damnit
Glemte den 1 sted ja. Good catch!
exoen
reviewed
Feb 14, 2022
| @@ -28,6 +30,11 @@ public class MeldingRequest : MeldingBase | |||
|
|
|||
| public MeldingSpesifikasjonApiModel ToApiModel() | |||
| { | |||
| if (KlientMeldingId != null && KlientMeldingId != Guid.Empty) | |||
There was a problem hiding this comment.
Kunne dette vært gjort i konstruktøren til MeldingsRequest? Trenger KlientMeldingId både være som prop på model og i header?
Jeg spør fordi metoden ToApiModel var i utgangspunktet uten side-effekt.
exoen
reviewed
Feb 14, 2022
| ExtractKlientMeldingId(); | ||
| } | ||
|
|
||
| private void ExtractKlientMeldingId() |
There was a problem hiding this comment.
Ville vurdert å returnere istedenfor å bruke sideeffekt, og brukt tryParse så ikke exception blir del av logikkflyten
private Guid ExtractKlientMeldingId()
{
if (Headere == null || !Headere.ContainsKey(headerKlientMeldingId))
{
return Guid.Empty;
}
if (Guid.TryParse(Headere[headerKlientMeldingId], out var id))
{
return id;
}
Logger.LogError("Kunne ikke parse KlientMeldingId funnet i header til guid. KlientMeldingId: {KlientMeldingId}", Headere[headerKlientMeldingId]);
return Guid.Empty;
}
exoen
approved these changes
Feb 15, 2022
exoen
approved these changes
Feb 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Se også PR for fiks-io-send-client-dotnet hvor klientMeldingId er tatt bort igjen som egen property.
Vi legger
klientMeldingIdinn som en header i stedet.