Pinning Kapre to 0.1.4 #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes you are right about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ksangeeta2429 Just like OpenL3, the EdgeL3 package is not compatible with the newer version of Kapre (1.7). And while the package can still be installed successfully via
pip install edgel3it is unusable, (i.e. calls toedgel3.get_embeddingoredgel3.models.load_embedding_modelerror out).The Kapre version should be pinned to
kapre==1.4, just like OpenL3 (see commit hereYou can check out the below Colab Notebooks for examples of the package failing with
kapre==1.7and working withkapre==1.4Resolves #4