Fix Venture non static methods
#48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you imagine how awkward it would've been if both us had agreed that the existing tests should be enough? 馃槄 Anyways, thanks for the quick fix! |
|
Haha yea super awkward right? Happy to help! 馃檹 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the non-static methods that I pushed in PR #44
I can't believe I didn't notice this 馃檲 Sorry @ksassnowski!
I've added the tests that I should have added originally with the PR. 馃檹
I've also added
workflow_idto the relationships so that the proper ID's are generated if a developer has a different workflow model class name (i.e.CustomWorkflowModel).