Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates Provider versions #10

Merged
merged 11 commits into from
Sep 4, 2020
Merged

Updates Provider versions #10

merged 11 commits into from
Sep 4, 2020

Conversation

ksatirli
Copy link
Owner

@ksatirli ksatirli commented Sep 3, 2020

This PR switches the base Terraform version from 0.12.20 to 0.13.x and updates the AWS Provider to 3.4.0.

I've also updated the examples to use underscores (_) instead of dashes (-) to separate resource names. This brings the code more in line with current best practices.

I intend to release this as module version 1.2.0.

@ksatirli ksatirli self-assigned this Sep 3, 2020
Copy link
Contributor

@onlydole onlydole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@onlydole
Copy link
Contributor

onlydole commented Sep 4, 2020

So, @ksatirli - it looks like region went to the big farm cloud in the sky 👼🏼 😄

https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/s3_bucket

…rraform-aws-s3-bucket into updates-provider-version

* 'updates-provider-version' of github.com:operatehappy/terraform-aws-s3-bucket:
  Remove S3 region as it is not supported in the v3.x AWS provider
Repository owner deleted a comment from github-actions bot Sep 4, 2020
@ksatirli ksatirli merged commit 8efa44f into master Sep 4, 2020
@ksatirli ksatirli deleted the updates-provider-version branch September 4, 2020 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants