Remove warning output from TcpClient#send #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kschiess
added a commit
that referenced
this pull request
Sep 23, 2014
Remove warning output from TcpClient#send
|
Included in the 0.6.0 Release as of today. |
|
Awesome, thanks for the support and for the great library! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was getting "closed stream" console output while running a TCP client/server and traced it to
TcpClient#send. Because the exception is re-raised, I don't think it's necessary towarnsince any clients can handle any raised exceptions themselves.In other words, it's trivial for clients to duplicate this behavior, but there's no way to suppress it.