feat: Migration to new architecture #123

dipankardas011 · 2023-07-07T17:11:57Z

Tasks description 🚧 🔧

Note
It is the parent PR from this Redesign architecture issue all other PR related to it should merge into this

### Issues
- [x] Closes #111
- [x] Closes #122
- [x] Closes #104
- [x] Closes #88
- [ ] Closes #87
- [ ] Closes #80
- [x] #125

Solution ✔️

Migration to the new Architecture design

Link for the latest architecture diagram https://www.figma.com/file/TM6aiNWMquYOxhCO23EKdT/ksctl?type=design&node-id=0%3A1&mode=design&t=Csg07pK02esAGQxU-1

Note to reviewers 📓

It should not be merged till the labels are assigned!
Before we merge this branch we need to update the CI as well
and increase the test coverage

Ran Unit Test locally
Tested the website locally

- added the basic look on the cmd part - added the interface for the 3 controllers - added the builder logic Signed-off-by: Dipankar Das <dipankardas0115@gmail.com> new emoji collections for the logging Signed-off-by: Dipankar Das <dipankardas0115@gmail.com> moved the create and delete subcommand to a 2 individual files Signed-off-by: Dipankar Das <dipankardas0115@gmail.com> improve: the branch to be more approachable for contributions Signed-off-by: Dipankar Das <dipankardas0115@gmail.com> started to restructure the api folder - added the previous api and cmd in backup dir Signed-off-by: Dipankar Das <dipankardas0115@gmail.com>

Signed-off-by: Dipankar Das <65275144+dipankardas011@users.noreply.github.com>

ex. nomad Signed-off-by: Dipankar Das <dipankardas0115@gmail.com>

Signed-off-by: Dipankar Das <dipankardas0115@gmail.com>

AvineshTripathi

With this review I have only looked into structuring, I've not seen into the inner working that I might see later but overall structure is currently my concern

api/provider/logger/noteMsg.go

api/provider/utils/main_test.go

cli/cmd/createCluster.go

dipankardas011 · 2023-07-08T07:30:21Z

With this review I have only looked into structuring, I've not seen into the inner working that I might see later but overall structure is currently my concern

Let's have a call some day 🙏

dipankardas011 · 2023-07-08T08:26:34Z

With this review I have only looked into structuring, I've not seen into the inner working that I might see later but overall structure is currently my concern

for this review we will solve them one by one, once we get going, that's why not resolving these conversations

Signed-off-by: Dipankar Das <dipankardas0115@gmail.com>

api/provider/local-bkp/main.go

api/provider/logger/main.go

api/provider/logger/noteMsg.go

Signed-off-by: Dipankar Das <dipankardas0115@gmail.com>

as the functionallity is more coupled towards the cobracli we can move it to a different place Signed-off-by: Dipankar Das <dipankardas0115@gmail.com>

Signed-off-by: Dipankar Das <dipankardas0115@gmail.com>

Signed-off-by: Dipankar Das <65275144+dipankardas011@users.noreply.github.com>

Signed-off-by: Dipankar Das <dipankardas0115@gmail.com>

codecov · 2023-08-14T17:43:00Z

Codecov Report

Merging #123 (bb971a1) into main (d223190) will increase coverage by 8.00%.
Report is 22 commits behind head on main.
The diff coverage is 12.70%.

❗ Current head bb971a1 differs from pull request most recent head 65bcaa6. Consider uploading reports for the commit 65bcaa6 to get more accurate results

@@            Coverage Diff            @@
##            main     #123      +/-   ##
=========================================
+ Coverage   4.88%   12.89%   +8.00%     
=========================================
  Files         17       25       +8     
  Lines       3152     3754     +602     
=========================================
+ Hits         154      484     +330     
- Misses      2990     3247     +257     
- Partials       8       23      +15

Files Changed	Coverage Δ
api/k8s_distro/k3s/k3scontroller.go	`0.00% <0.00%> (ø)`
api/provider/azure/firewall.go	`0.00% <0.00%> (ø)`
api/provider/azure/managed_main.go	`0.00% <0.00%> (ø)`
api/provider/azure/network.go	`0.00% <0.00%> (ø)`
api/provider/azure/ssh.go	`0.00% <0.00%> (ø)`
api/provider/azure/vm.go	`0.00% <0.00%> (ø)`
api/provider/civo/firewall.go	`0.00% <0.00%> (ø)`
api/provider/civo/managed_main.go	`0.00% <0.00%> (ø)`
api/provider/civo/network.go	`0.00% <0.00%> (ø)`
api/provider/civo/ssh.go	`0.00% <0.00%> (ø)`
... and 15 more

Signed-off-by: Dipankar Das <dipankardas0115@gmail.com>

github-advanced-security · 2023-08-15T12:25:06Z

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

it was using uninitalized state variable changed it to use the cluster name passed Signed-off-by: Dipankar Das <dipankardas0115@gmail.com> removal of fixme for k3s version Signed-off-by: Dipankar Das <dipankardas0115@gmail.com> upated the readme Signed-off-by: Dipankar Das <dipankardas0115@gmail.com> bug-fix(civo): managed kubernetes version not getting saved in cloud state Signed-off-by: Dipankar Das <dipankardas0115@gmail.com> removed region as required field in switch Signed-off-by: Dipankar Das <dipankardas0115@gmail.com> added flag for skipping approval step Signed-off-by: Dipankar Das <dipankardas0115@gmail.com>

feat(jenkinsfile): added Signed-off-by: Dipankar Das <dipankardas0115@gmail.com>

Signed-off-by: Dipankar Das <dipankardas0115@gmail.com>

dipankardas011 · 2023-08-17T14:44:12Z

TODOs

ksctl core

Update docs

enable CI pipelines

Add test cases by simple function calls

add mocks by using interfaces

the mocks will be taken up after this PR

…w-architecture feat: Migration to new architecture

github-actions bot added kind/documentation area/internal labels Jul 7, 2023

dipankardas011 force-pushed the 111-feature-migration-to-new-architecture branch from 238b0e2 to 42c0161 Compare July 7, 2023 17:26

Merge branch 'main' into 111-feature-migration-to-new-architecture

688cfff

Signed-off-by: Dipankar Das <65275144+dipankardas011@users.noreply.github.com>

dipankardas011 changed the title ~~111 feature migration to new architecture~~ feat: Migration to new architecture Jul 7, 2023

dipankardas011 requested a review from AvineshTripathi July 7, 2023 17:29

dipankardas011 added this to the New API Designing milestone Jul 7, 2023

dipankardas011 added 2 commits July 7, 2023 23:18

Support for the non-k8s distros

f867fe5

ex. nomad Signed-off-by: Dipankar Das <dipankardas0115@gmail.com>

Added interface for the restAPI client

02fb8f3

Signed-off-by: Dipankar Das <dipankardas0115@gmail.com>

AvineshTripathi reviewed Jul 8, 2023

View reviewed changes

dipankardas011 added 2 commits July 9, 2023 15:04

Decided on the overall all interfaces

bbd2b0e

Signed-off-by: Dipankar Das <dipankardas0115@gmail.com>

Fixed the import error

e182f38

Signed-off-by: Dipankar Das <dipankardas0115@gmail.com>

AvineshTripathi reviewed Jul 9, 2023

View reviewed changes

api/provider/local-bkp/main.go Outdated Show resolved Hide resolved

api/provider/logger/main.go Outdated Show resolved Hide resolved

api/provider/logger/noteMsg.go Outdated Show resolved Hide resolved

api/provider/logger/noteMsg.go Outdated Show resolved Hide resolved

dipankardas011 added 8 commits July 9, 2023 20:06

Added the K3s and Kubeadm interface and mock-cli working

0ef21b8

Signed-off-by: Dipankar Das <dipankardas0115@gmail.com>

Added the Local provider

43fb11b

Signed-off-by: Dipankar Das <dipankardas0115@gmail.com>

Added the Storage Handlers

a6f20a1

Signed-off-by: Dipankar Das <dipankardas0115@gmail.com>

Moved the NewBuilder funcs to the resources/cli

7af66f4

as the functionallity is more coupled towards the cobracli we can move it to a different place Signed-off-by: Dipankar Das <dipankardas0115@gmail.com>

test: added for resources/engine.go

ec34d65

Signed-off-by: Dipankar Das <dipankardas0115@gmail.com>

Added rough folder structure for the civo provider

71af41b

Signed-off-by: Dipankar Das <dipankardas0115@gmail.com>

fix: github actions labaler

8bd3b12

Signed-off-by: Dipankar Das <dipankardas0115@gmail.com>

Improved the labaler filters

eadc155

Signed-off-by: Dipankar Das <dipankardas0115@gmail.com>

dipankardas011 added kind/enhancement New feature or request cloud/civo cloud cloud/local local cloud/azure azure priority/high highest priority labels Jul 12, 2023

dipankardas011 and others added 5 commits August 14, 2023 09:30

feat(cli): added the cli

6a4a716

Signed-off-by: Dipankar Das <dipankardas0115@gmail.com>

Merge branch 'main' into 111-feature-migration-to-new-architecture

2f80689

Signed-off-by: Dipankar Das <65275144+dipankardas011@users.noreply.github.com>

feat(ci): completed cli bug fixes

6b0a5e3

Signed-off-by: Dipankar Das <dipankardas0115@gmail.com>

update(gh): commented the test for api

10f7158

Signed-off-by: Dipankar Das <dipankardas0115@gmail.com>

feat(gh,test): added unit tests, gh CI enabled

fe5a3a2

Signed-off-by: Dipankar Das <dipankardas0115@gmail.com>

dipankardas011 added 2 commits August 14, 2023 23:19

enhancement(azure-test): noWP(), noCP(), noDS()

a3c363e

Signed-off-by: Dipankar Das <dipankardas0115@gmail.com>

fix(windows-test): wrong path for utils folder

e29dd5c

Signed-off-by: Dipankar Das <dipankardas0115@gmail.com>

dipankardas011 removed the status/in-progress label Aug 15, 2023

feat(docs): updated docs

2282b2c

Signed-off-by: Dipankar Das <dipankardas0115@gmail.com>

github-actions bot added provider/azure labels Aug 15, 2023

dipankardas011 removed provider/azure labels Aug 15, 2023

github-actions bot added provider/azure labels Aug 15, 2023

dipankardas011 added pr/mergable This PR is waiting to get merged pr/lgtm This PR look good to the reviewer labels Aug 16, 2023

dipankardas011 added 3 commits August 17, 2023 20:10

bug-fix(ha-civo,ha-azure): fixed the switch context

34e5ec5

feat(jenkinsfile): added Signed-off-by: Dipankar Das <dipankardas0115@gmail.com>

feat(e2e): Added test file for jenkins to work

65bcaa6

Signed-off-by: Dipankar Das <dipankardas0115@gmail.com>

dipankardas011 force-pushed the 111-feature-migration-to-new-architecture branch from bb971a1 to 65bcaa6 Compare August 17, 2023 14:42

dipankardas011 merged commit 043ac99 into main Aug 17, 2023
15 checks passed

dipankardas011 deleted the 111-feature-migration-to-new-architecture branch January 7, 2024 10:15

dipankardas011 added a commit that referenced this pull request Jan 9, 2024

Merge pull request #123 from kubesimplify/111-feature-migration-to-ne…

81b2cf3

…w-architecture feat: Migration to new architecture

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Migration to new architecture #123

feat: Migration to new architecture #123

dipankardas011 commented Jul 7, 2023 •

edited

Loading

AvineshTripathi left a comment

dipankardas011 commented Jul 8, 2023

dipankardas011 commented Jul 8, 2023

codecov bot commented Aug 14, 2023 •

edited

Loading

github-advanced-security bot commented Aug 15, 2023

dipankardas011 commented Aug 17, 2023

TODOs

feat: Migration to new architecture #123

feat: Migration to new architecture #123

Conversation

dipankardas011 commented Jul 7, 2023 • edited Loading

Tasks description 🚧 🔧

Solution ✔️

Note to reviewers 📓

AvineshTripathi left a comment

Choose a reason for hiding this comment

dipankardas011 commented Jul 8, 2023

dipankardas011 commented Jul 8, 2023

codecov bot commented Aug 14, 2023 • edited Loading

Codecov Report

github-advanced-security bot commented Aug 15, 2023

dipankardas011 commented Aug 17, 2023

TODOs

dipankardas011 commented Jul 7, 2023 •

edited

Loading

codecov bot commented Aug 14, 2023 •

edited

Loading