Command expansion changes #1

tdaron · 2024-07-03T08:44:25Z

Hi !

I didn't know how to propose my changes into the PR, so i thought the simpler would be to create one here !

I created a new branch on master directly cause i prefered directly re-doing your work (mainly copy pasting haha) on master rather than resolving conflicts.

I can create a new PR (on the original helix repo) if you don't want to handle this (or you can also give me contributing access to this repo, it's however you prefer :) )

Have a great day !

(this PR contains every change on helix master as well, sycing your repo should make them disapear)

* flush saves before suspending * review suggestion Co-authored-by: Kirawi <67773714+kirawi@users.noreply.github.com> * review changes --------- Co-authored-by: PotatoesFall <martyk@tuta.io> Co-authored-by: Kirawi <67773714+kirawi@users.noreply.github.com>

…10873)

* Add `py` as valid python injection regex * Add `hs` and `rs` for `haskell` and `rust` * Add `typ` injection regex for `typst`

* add elisp support * update queries for some constants

…ement (helix-editor#10786) * Remove special-casing of line ending characters in selection replacement * Refactor line ending handling and integration test to address code review comments

…-editor#10880)

* auto save after delay * configable * clearer names * init * working with some odd behaviour * working with greater consistency * Apply reviewer suggestions - Remove unneccessary field - Remove blocking save * Improve auto-save configuration Auto save can be configured to trigger on focus loss: ```toml auto-save.focus-lost = true|false ``` and after a time delay (in milli seconds) since last keypress: ```toml auto-save.after-delay.enable = true|false auto-save.after-delay.timeout = [0, u64::MAX] # default: 3000 ``` * Remove boilerplate and unnecessary types * Remove more useless types * Update docs for auto-save.after-delay * Fix wording of (doc) comments relating to auto-save * book: Move auto-save descriptions to separate section --------- Co-authored-by: Miguel Perez <miguelvojito@gmail.com> Co-authored-by: Miguel Perez <perezoji@cs.fsu.edu>

…#10910)

… 5 updates (helix-editor#10926) * build(deps): bump the rust-dependencies group across 1 directory with 5 updates Bumps the rust-dependencies group with 5 updates in the / directory: | Package | From | To | | --- | --- | --- | | [unicode-width](https://github.com/unicode-rs/unicode-width) | `0.1.12` | `0.1.13` | | [regex](https://github.com/rust-lang/regex) | `1.10.4` | `1.10.5` | | [url](https://github.com/servo/rust-url) | `2.5.0` | `2.5.1` | | [open](https://github.com/Byron/open-rs) | `5.1.3` | `5.1.4` | | [cc](https://github.com/rust-lang/cc-rs) | `1.0.98` | `1.0.99` | Updates `unicode-width` from 0.1.12 to 0.1.13 - [Commits](unicode-rs/unicode-width@v0.1.12...v0.1.13) Updates `regex` from 1.10.4 to 1.10.5 - [Release notes](https://github.com/rust-lang/regex/releases) - [Changelog](https://github.com/rust-lang/regex/blob/master/CHANGELOG.md) - [Commits](rust-lang/regex@1.10.4...1.10.5) Updates `url` from 2.5.0 to 2.5.1 - [Release notes](https://github.com/servo/rust-url/releases) - [Commits](servo/rust-url@v2.5.0...v2.5.1) Updates `open` from 5.1.3 to 5.1.4 - [Release notes](https://github.com/Byron/open-rs/releases) - [Changelog](https://github.com/Byron/open-rs/blob/main/changelog.md) - [Commits](Byron/open-rs@v5.1.3...v5.1.4) Updates `cc` from 1.0.98 to 1.0.99 - [Release notes](https://github.com/rust-lang/cc-rs/releases) - [Commits](rust-lang/cc-rs@1.0.98...1.0.99) --- updated-dependencies: - dependency-name: unicode-width dependency-type: direct:production update-type: version-update:semver-patch dependency-group: rust-dependencies - dependency-name: regex dependency-type: direct:production update-type: version-update:semver-patch dependency-group: rust-dependencies - dependency-name: url dependency-type: direct:production update-type: version-update:semver-patch dependency-group: rust-dependencies - dependency-name: open dependency-type: direct:production update-type: version-update:semver-patch dependency-group: rust-dependencies - dependency-name: cc dependency-type: direct:production update-type: version-update:semver-patch dependency-group: rust-dependencies ... Signed-off-by: dependabot[bot] <support@github.com> * helix-tui: Use zero-width-space for zero-width grapheme test The update of unicode-width 0.1.13 in the parent commit changed the width of the U+1 codepoint to 1 from 0, causing the test to fail. We can switch to a well known zero-width codepoint of U+200B to fix the behavior. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Michael Davis <mcarsondavis@gmail.com>

* feat(cairo): update tree-sitter grammar and queries * fix suggestions

Fix helix-editor#10560 by accepting an optional history register for the rename_symbol command.

unicode-width 0.1.13 contains some fixes that change the widths of line endings, which breaks some assumptions in helix-tui, causing some rendering artifacts. We can downgrade to remove the rendering errors for now.

* Fix deserialization of id * Removing external dependencies This reverts commit 27962af. * Fix incorrect import * Adding tests * Moved tests --------- Co-authored-by: Sławomir Lech <slawomir.lech@bluesoft.com>

* Resolve issue helix-editor#10874 * cargo fmt

…or#10968) * Fix jump_backwards behaviour when jumplist is at capacity * Decrement self.current while popping from front * Fix issue with conflicting updates to self.current * Realised that truncate is intentional * Use saturating_sub when decrementing current * Fix naming of previous jump, and remove unneeded comment change * Remove unnecessary changes in push * Return num elements removed from front, and use in backward method * Hide num_removed from public interface and tidy up jump location check

* Fix multiple broken links in the documentation * Apply code review suggestion Co-authored-by: Michael Davis <mcarsondavis@gmail.com> --------- Co-authored-by: Michael Davis <mcarsondavis@gmail.com>

…uments (helix-editor#10733) * Implement check before adding path to files * fix problem where directories were removed from args.files * Revert "Implement check before adding path to files" This reverts commit c123944. * Dissallow opening of irregular non-symlink files * Fixed issue with creating new file from command line * Fixed linting error. * Optimized regularity check as suggested in review * Created DocumentOpenError Sum Type to switch on in Application * Forgot cargo fmt * Update helix-term/src/application.rs Accept suggestion in review. Co-authored-by: Michael Davis <mcarsondavis@gmail.com> * Moved thiserror version configuration to the workspace instead of the individual packages. --------- Co-authored-by: Michael Davis <mcarsondavis@gmail.com>

Update to latest commit on master to include fix for a bug that doesn't allow spaces in the shebang line.

)

…ditor#10989)" (helix-editor#11006) This reverts commit 9b7dffb.

…itor#10978) When parsing injections, we skip adding a new layer if there is an existing layer covering the same range. When doing so we did not update the parent layer ID, so some layers could have `parent` layer IDs that pointed to a layer that no longer existed in the `layers` HopSlotMap which could cause a panic when using `A-o`. To fix this we update the `parent` pointer for both newly created injection layers and reused ones.

…0858) * base16_default: add `ui.statusline` for `color-modes` Signed-off-by: J. Dekker <jdek@itanimul.li> * base16_default: add `ui.virtual` default Previously virtual text such as LSP inlay was impossible to distinguish from 'real' text by default. Signed-off-by: J. Dekker <jdek@itanimul.li> --------- Signed-off-by: J. Dekker <jdek@itanimul.li>

…itor#11099)

* refactor `starting_request_args` to only `ref` non-`Copy` * refactor `needs_recompile` to only `ref` non-`Copy` * refactor `add_workspace_folder` to only `ref` `Some` --------- Co-authored-by: Rudxain <rudxain@localhost.localdomain>

…ditor#11113) Bumps the rust-dependencies group with 5 updates: | Package | From | To | | --- | --- | --- | | [serde](https://github.com/serde-rs/serde) | `1.0.203` | `1.0.204` | | [imara-diff](https://github.com/pascalkuthe/imara-diff) | `0.1.5` | `0.1.6` | | [clipboard-win](https://github.com/DoumanAsh/clipboard-win) | `5.3.1` | `5.4.0` | | [open](https://github.com/Byron/open-rs) | `5.1.4` | `5.2.0` | | [cc](https://github.com/rust-lang/cc-rs) | `1.0.104` | `1.0.106` | Updates `serde` from 1.0.203 to 1.0.204 - [Release notes](https://github.com/serde-rs/serde/releases) - [Commits](serde-rs/serde@v1.0.203...v1.0.204) Updates `imara-diff` from 0.1.5 to 0.1.6 - [Release notes](https://github.com/pascalkuthe/imara-diff/releases) - [Changelog](https://github.com/pascalkuthe/imara-diff/blob/master/CHANGELOG.md) - [Commits](pascalkuthe/imara-diff@v0.1.5...v0.1.6) Updates `clipboard-win` from 5.3.1 to 5.4.0 - [Commits](https://github.com/DoumanAsh/clipboard-win/commits) Updates `open` from 5.1.4 to 5.2.0 - [Release notes](https://github.com/Byron/open-rs/releases) - [Changelog](https://github.com/Byron/open-rs/blob/main/changelog.md) - [Commits](Byron/open-rs@v5.1.4...v5.2.0) Updates `cc` from 1.0.104 to 1.0.106 - [Release notes](https://github.com/rust-lang/cc-rs/releases) - [Changelog](https://github.com/rust-lang/cc-rs/blob/main/CHANGELOG.md) - [Commits](rust-lang/cc-rs@cc-v1.0.104...cc-v1.0.106) --- updated-dependencies: - dependency-name: serde dependency-type: direct:production update-type: version-update:semver-patch dependency-group: rust-dependencies - dependency-name: imara-diff dependency-type: direct:production update-type: version-update:semver-patch dependency-group: rust-dependencies - dependency-name: clipboard-win dependency-type: direct:production update-type: version-update:semver-minor dependency-group: rust-dependencies - dependency-name: open dependency-type: direct:production update-type: version-update:semver-minor dependency-group: rust-dependencies - dependency-name: cc dependency-type: direct:production update-type: version-update:semver-patch dependency-group: rust-dependencies ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…ditor#11118)

* Add changes before insert mode undo Fixes helix-editor#11077 * Address edge cases for undo like Kakoune does --------- Co-authored-by: Kaniel Kirby <pirate7007@runbox.com> Co-authored-by: Michael Davis <mcarsondavis@gmail.com>

Previously `gf` on `~/.config/helix` for example would error if the entire path was selected but succeed and open a picker for the directory contents if the selection was one one-width cursor. We need to expand tildes for all paths instead of just the auto-detected paths. This also refactors the `goto_file` blocks a little so that we construct `paths` once instead of creating the Vec and immediately clearing it when the selection is one single-width cursor.

* feat: improve hx fish completion - add -w and --working-dir options - shorten option description - dynamically call hx --health * feat: improve health check completion - remove header - remove check/x characters * feat: use hx --health languages in completion

…or#11117)

…helix-editor#11115)

This change uses <https://git.sr.ht/~ecs/tree-sitter-hare/> that is up-to-date and linked from the official documentation.

Update to latest commit that allows any non-whitespace character for projects, and contexts.

This fixes the modification indicator when saving from insert mode with a config such as [keys.insert] C-s = ":write" Previously the modification indicator would be stuck showing modified even if the buffer contents matched the disk contents when writing after some changes in insert mode with this binding. In insert mode we do not eagerly write undo checkpoints so that all changes made become one checkpoint as you exit insert mode. When saving, `Document`s `changes` `ChangeSet` would be non-empty and when there are changes we show the buffer as modified. Then switching to normal mode would append the changes to history, bumping the current revision past what it was when last saved. Since the last saved revision and current revision were then unsynced, the modification indicator would always show modified. This matches [Kakoune's behavior]. Kakoune has a different architecture for writes but a very similar system for history, transactions and undo checkpoints (what it calls "undo groups"). Upon saving Kakoune creates an undo checkpoint if there are any uncommitted changes. It does this after the write has gone through since its writing system is different. For our writing system it's cleaner to make the undo checkpoint before performing the save so that the history revision increments before we send the save event. [Kakoune's behavior]: https://github.com/mawww/kakoune/blob/80fcfebca8c62ace6cf2af9487784486af07d2d5/src/buffer.cc#L565-L566

Implements the Dragon variant of the Kanagawa theme. https://github.com/rebelot/kanagawa.nvim?tab=readme-ov-file

PotatoesFall and others added 30 commits June 5, 2024 18:47

LSP: Resolve completion items when any info is missing (helix-editor#…

6f1437e

…10873)

Fix logic to update version when HEAD changes. (helix-editor#10896)

886d307

"it's" -> "its", in crossterm.rs (helix-editor#10860)

3a03109

Add py, hs, rs and typ injection regexes (helix-editor#10785)

80e0e98

* Add `py` as valid python injection regex * Add `hs` and `rs` for `haskell` and `rust` * Add `typ` injection regex for `typst`

add elisp support (helix-editor#10644)

44504b7

* add elisp support * update queries for some constants

Update Swift Grammar and Queries (helix-editor#10802)

aa1630a

Remove special handling of line ending characters in selection replac…

03813bb

…ement (helix-editor#10786) * Remove special-casing of line ending characters in selection replacement * Refactor line ending handling and integration test to address code review comments

in flake mkShell default RUSTFLAGS to an empty string if unset (helix…

a1cda3c

…-editor#10880)

Improve readability of virtual text with 'noctis' theme (helix-editor…

a64dbf8

…#10910)

feat(cairo): update tree-sitter grammar and queries (helix-editor#10919)

9123d3f

* feat(cairo): update tree-sitter grammar and queries * fix suggestions

Optional history for rename_symbol (helix-editor#10932)

62655e9

Fix helix-editor#10560 by accepting an optional history register for the rename_symbol command.

fix(editor): prevent overflow in count modifier (helix-editor#10930)

9c479e6

Downgrade unicode-width to 0.1.12 (helix-editor#10963)

8eda96d

unicode-width 0.1.13 contains some fixes that change the widths of line endings, which breaks some assumptions in helix-tui, causing some rendering artifacts. We can downgrade to remove the rendering errors for now.

Sync latest Catppuccin themes changes (helix-editor#10954)

43cc30d

DAP: Deserialize number IDs (helix-editor#10943)

dbacaad

* Fix deserialization of id * Removing external dependencies This reverts commit 27962af. * Fix incorrect import * Adding tests * Moved tests --------- Co-authored-by: Sławomir Lech <slawomir.lech@bluesoft.com>

Make prompt use cursor set for Insert mode (helix-editor#10945)

bc73dd1

* Resolve issue helix-editor#10874 * cargo fmt

improve jump colors for github_dark themes (helix-editor#10946)

afe9049

Add curly single and double quotes to BRACKETS (helix-editor#10971)

69acf66

Fix multiple broken links in the documentation (helix-editor#10953)

d70f58d

* Fix multiple broken links in the documentation * Apply code review suggestion Co-authored-by: Michael Davis <mcarsondavis@gmail.com> --------- Co-authored-by: Michael Davis <mcarsondavis@gmail.com>

Update tree-sitter-rust (helix-editor#10973)

0edf609

Update to latest commit on master to include fix for a bug that doesn't allow spaces in the shebang line.

Replace unicode-general-category with icu-properties (helix-editor#10989

9b7dffb

)

Revert "Replace unicode-general-category with icu-properties (helix-e…

b55cb3a

…ditor#10989)" (helix-editor#11006) This reverts commit 9b7dffb.

Add block comment tokens for typst (helix-editor#10955)

3706c0d

matta and others added 23 commits July 7, 2024 02:40

Minor improvements to comments in selection.rs (helix-editor#11101)

8b7c33d

add cursorcolumn and cursorline to base16_transparent theme (helix-ed…

0c8d51e

…itor#11099)

&Option<T> -> Option<&T> (helix-editor#11091)

6997ee9

* refactor `starting_request_args` to only `ref` non-`Copy` * refactor `needs_recompile` to only `ref` non-`Copy` * refactor `add_workspace_folder` to only `ref` `Some` --------- Co-authored-by: Rudxain <rudxain@localhost.localdomain>

Fix heredoc and add ansi_c_string highlights in bash queries (helix-e…

71df242

…ditor#11118)

Add changes for undo in insert mode (helix-editor#11090)

86e4b51

* Add changes before insert mode undo Fixes helix-editor#11077 * Address edge cases for undo like Kakoune does --------- Co-authored-by: Kaniel Kirby <pirate7007@runbox.com> Co-authored-by: Michael Davis <mcarsondavis@gmail.com>

Update fleet_dark.toml (helix-editor#11046)

bfb7023

Add basedpyright langserver (helix-editor#11121)

649bd45

Update ZSH completions (helix-editor#11120)

9d75385

Add space back to main text in the tutor after chapter 11 (helix-edit…

8229a40

…or#11117)

Add {pdm,uv}.lock, git/ignore, npmrc to languages (helix-editor#11131)

2d1ac0f

Documentation: Convert links in the .desktop file to absolute paths (…

501af93

…helix-editor#11115)

Fix ZSH completions (helix-editor#11133)

a75b1cf

refactor(commands): trim end of pipe-like output (helix-editor#10952)

fd7b1a3

Include .yml files in Helm chart templates (helix-editor#11135)

b0f3fe7

Update Hare grammar (helix-editor#11130)

ec0bdb3

This change uses <https://git.sr.ht/~ecs/tree-sitter-hare/> that is up-to-date and linked from the official documentation.

Add regex injections into bash (helix-editor#11112)

928e3f0

Update tree-sitter-todotxt (helix-editor#11097)

35f1c2a

Update to latest commit that allows any non-whitespace character for projects, and contexts.

Theme: Kanagawa Dragon (helix-editor#10172)

e6bf97b

Implements the Dragon variant of the Kanagawa theme. https://github.com/rebelot/kanagawa.nvim?tab=readme-ov-file

Exclude EOL repos from the Repology badge (helix-editor#11159)

c9b4840

tdaron force-pushed the command-expansion branch from 92beac3 to 21f1bb9 Compare July 14, 2024 13:44

tdaron added 3 commits July 14, 2024 18:33

command expansion

731985c

command expansion: parsing expansions in shellwords accordingly.

11a11fb

Merge branch 'helix-editor:master' into command-expansion

0d97406

tdaron force-pushed the command-expansion branch from 21f1bb9 to 726f874 Compare July 14, 2024 16:33

fixing shellwords

c3eff3e

tdaron force-pushed the command-expansion branch from 726f874 to c3eff3e Compare July 15, 2024 08:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Command expansion changes #1

Command expansion changes #1

tdaron commented Jul 3, 2024 •

edited

Loading

Command expansion changes #1

Are you sure you want to change the base?

Command expansion changes #1

Conversation

tdaron commented Jul 3, 2024 • edited Loading

tdaron commented Jul 3, 2024 •

edited

Loading