Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for additional frameworks scikit/xgboost/pytorch #18

Closed
ellistarn opened this issue Apr 11, 2019 · 3 comments
Closed

Support for additional frameworks scikit/xgboost/pytorch #18

ellistarn opened this issue Apr 11, 2019 · 3 comments

Comments

@ellistarn
Copy link
Contributor

We need performant model servers for each of these technologies and auto-wiring via high level specs analogous to TensorflowSpec

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label feature_request to this issue, with a confidence of 0.96. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: dashboard, app homepage and code for this bot.

@ellistarn
Copy link
Contributor Author

Complete with our 0.1 release
/close

@k8s-ci-robot
Copy link
Contributor

@ellis-bigelow: Closing this issue.

In response to this:

Complete with our 0.1 release
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Surya-smart619 pushed a commit to Surya-smart619/kserve that referenced this issue May 11, 2022
dtrifiro pushed a commit to dtrifiro/kserve that referenced this issue Nov 22, 2023
…erve#18)

**What this does / why we need it**:

    This PR adds custom code to make KServe run on OpenShift without the need for anyuid SCC.

**More context**:

OpenShift uses istio-cni which causes an issue with init-containers when calling external services
like S3 or similar. Setting the uid for the storage-initializer to the same uid as the
uid of the istio-proxy resolves the issue. In OpenShift the istio-proxy always gets assigned
the first uid from the namespaces uid range + 1 (The range is defined in an annotation on the namespace).

**Release note**:

```release-note
The `storage-initializer` container will now run with the same `uid` as the `istio-proxy` which resolves an issue when istio-cni is used.
```

---
Squashed commit titles:
* add storage-initializer uid handling for OpenShift with istio-cni
* update storage_initializer_injector tests
* Also use annotation on pod to override uid
terrytangyuan pushed a commit to terrytangyuan/kserve that referenced this issue May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants