Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transformer examples uses incorrect function definition #2258

Closed
smhgit opened this issue Jun 19, 2022 · 3 comments
Closed

Transformer examples uses incorrect function definition #2258

smhgit opened this issue Jun 19, 2022 · 3 comments

Comments

@smhgit
Copy link

smhgit commented Jun 19, 2022

/kind bug

Example use List def postprocess(self, inputs: List) -> List:

While base uses Dict def postprocess(self, response: Union[Dict, ModelInferResponse]) -> Dict:

def postprocess(self, response: Union[Dict, ModelInferResponse]) -> Dict:

@yuzisun
Copy link
Member

yuzisun commented Jun 19, 2022

@smhgit Thanks for catching this! Are you interested to contribute the fix?

@smhgit
Copy link
Author

smhgit commented Jun 22, 2022

@yuzisun sure, will take a look how to make contribution here.

kserve-oss-bot pushed a commit that referenced this issue Jun 30, 2022
* Fix incorrect function definition, issue #2258

Signed-off-by: Eyal Cohen <eyalcohen@eyals-mbp.haifa.il.ibm.com>
Signed-off-by: Eyal Cohen <eyalcohen@sig-9-145-160-25.de.ibm.com>

* Fix lint - unused imported

Signed-off-by: Eyal Cohen <eyalcohen@sig-9-145-160-25.de.ibm.com>

Co-authored-by: Eyal Cohen <eyalcohen@eyals-mbp.haifa.il.ibm.com>
@yuzisun
Copy link
Member

yuzisun commented Jul 3, 2022

Fixed in #2266

@yuzisun yuzisun closed this as completed Jul 3, 2022
alexagriffith pushed a commit to alexagriffith/kserve that referenced this issue Sep 19, 2022
* Fix incorrect function definition, issue kserve#2258

Signed-off-by: Eyal Cohen <eyalcohen@eyals-mbp.haifa.il.ibm.com>
Signed-off-by: Eyal Cohen <eyalcohen@sig-9-145-160-25.de.ibm.com>

* Fix lint - unused imported

Signed-off-by: Eyal Cohen <eyalcohen@sig-9-145-160-25.de.ibm.com>

Co-authored-by: Eyal Cohen <eyalcohen@eyals-mbp.haifa.il.ibm.com>
Signed-off-by: alexagriffith <agriffith96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants