-
Notifications
You must be signed in to change notification settings - Fork 986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes in Seldon open source license to BSL #3380
Comments
Here are two links for more context: First, we need to confirm which components that we currently use are now licensed differently. After that, I guess there are a few options for next steps:
|
Two action items I think:
|
@yuzisun are we losing anything significant if we get rid of alibi? Should we start an effort to make something similar in a truly open source way? (I'm sure we can get organizations to provide resources if necessary) We could even start with the code base from the previously Apache 2.0 licensed alibi (if it's any good). |
I am not sure how many KServe users are using Alibi, currently KServe is depending on Alibi 0.9.4 which is still under Apache license according to FAQ. I think what we can do is to remove alibi type from the inference service yaml specification. User can still use previous alibi versions(<0.9.5) under apache license via custom explainer spec. We did this when we deprecated AIX explainer and left an example using custom explainer spec for AIX. |
@yuzisun Sounds good. We'll work on a PR to address this.
@thesuperzapper I have a separate proposal to integrate with TrustyAI. See #3381 for details. |
Let's use this issue to discuss Seldon-related dependencies. We are working on the removal of Alibi as outlined by @yuzisun #3380 (comment) and provide an example as custom explainer. Regarding a fork, I doubt that we'd want to rely on vendor-maintained fork and don't want to have the risk of the fork going unmaintained again at some point. |
@terrytangyuan @TimKleinloog if there is sufficient user-demand, and a group willing to maintain a fork of Alibi, I don't see a harm in at least starting the discussion. |
@terrytangyuan I also would like to use this issue to propose an alternative, since I don’t see a custom explainer as a good alternative. Especially in the EU where we are active explainability will increase in importance (due to transparency obligations in AI regulation). I would like to strengthen the position of KServe in this field in stead of weakening it. |
We can still bring in explainer runtime installed out of the box from kserve when we have a good alternative just like we provide triton, torchserve predictor runtimes. I am suggesting to remove the hard coded explainer type(alibi) from inference service spec and make it more extensible so later we can bring in the official explainer runtime. If people still want alibi they can use custom explainer, does this sound good to you ? |
I see that there is lot of traction about explainability. While we are going ahead to remove the alibi, we should already set some targets for what alternative can be provided. So I agree with @TimKleinloog @thesuperzapper maybe we should already start working upon other options. Because I think explainability in production level setting is still one of USPs of kserve, I would not like it become completely custom because it really reduces reusability of whatever standards are out there for explainability. |
@yuzisun that sounds like a solid plan. I would like to align our efforts to be able to create and maintain an explainer runtime, so we immediately can have an alternative. |
Just to be clear it is not custom, we want to make explainer pluggable as predictors so user can easily add explainer runtimes. kserve still ships a few official explainer runtimes out of the box. I am only suggesting using custom for alibi if people want to. |
Sounds good, so in this issue we just scope removal of alibi. And in the other issues like one suggested by @TimKleinloog #3991. @terrytangyuan #3381 we should take up integration of new runtime approaches for explainability. |
I am moving the pluggable explainer to a separate issue to track #3398 |
/assign |
Hi @yuzisun / @terrytangyuan is this the plan going forward, even though MLServer is still Apache 2.0? We are actually considering migrating from SeldonCore to KServe cause we could "just" switch the backend over to KServe but keep the models running on MLServer (for now, while we migrate them 1 by 1 later). |
@yuzisun @terrytangyuan can we confirm if we are planning to keep using MLServer in KServe? It seems to still be Apache 2.0: |
I don’t think we can remove it yet. See #3443 (comment) |
I know it;s a closed issue but does normal kserve serving runtime have the option of injecting version like mlserver had? Currently am using MlServe. So just wanted to know this before migration. |
* wip Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * comment out Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * fix wf Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * helm test Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * remove mlserver relate tests Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * fix lint Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * sklearnserver runtime Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * Fix test Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * fix Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * disable check Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * reunused imports Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * Add back mlserver Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * pre-commit fix Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * update storage url Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * fix build Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * fix codegen Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * revert uri Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * int_contents Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * Remove unused script Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * remove dockerfile Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * Empty-Commit Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * Empty-Commit Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * Empty-Commit Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> --------- Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> Signed-off-by: tjandy98 <3953059+tjandy98@users.noreply.github.com>
We need to take some actions on the recent change of license in Seldon projects since we have Alibi integration for the explainer.
Here's the full email from Seldon regarding the license change:
The text was updated successfully, but these errors were encountered: