Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dep with Knative dependency and add knative service placeholder #10

Merged
merged 2 commits into from
Apr 5, 2019
Merged

Update dep with Knative dependency and add knative service placeholder #10

merged 2 commits into from
Apr 5, 2019

Conversation

yuzisun
Copy link
Member

@yuzisun yuzisun commented Apr 5, 2019 •
edited

  • Add knative dependency to Gopkg.toml, knative is on kube 1.12 and the latest controller-runtime version for kube 1.12 is 0.1.9

  • Add knative service for placeholder in main controller reconcile function

  • Add vendor files and the only files interested to review are Gopkg.toml and kfservice_controller.go

This change is Reviewable

ellistarn
ellistarn reviewed Apr 5, 2019
View reviewed changes
Copy link
Contributor

@ellistarn ellistarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you just needed to reference knative to ensure the deps were all healthy.
/lgtm
/approval

@k8s-ci-robot k8s-ci-robot added lgtm and removed lgtm labels Apr 5, 2019
@yuzisun
Copy link
Member Author

yuzisun commented Apr 5, 2019

@ellis-bigelow sorry can you lgtm again ? I removed an unused dependency.

ellistarn
ellistarn reviewed Apr 5, 2019
View reviewed changes
Gopkg.toml

[[constraint]]
name = "github.com/knative/serving"
version = "v0.5.0"
Copy link
Contributor

@ellistarn ellistarn Apr 5, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we locking this version w/ a constraint? In my prototype I put this as a requirement.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it is good to lock the version, since required may find the latest version and your current code may break, maybe I do not fully understand how required works.

ellistarn
ellistarn reviewed Apr 5, 2019
View reviewed changes
Copy link
Contributor

@ellistarn ellistarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Consider "fixup" on your commits to keep the history more clean.

@yuzisun
Copy link
Member Author

yuzisun commented Apr 5, 2019

Nit: Consider "fixup" on your commits to keep the history more clean.

cleaned up.

@ellistarn
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ellis-bigelow

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ellistarn
Copy link
Contributor

I read through https://github.com/golang/dep/blob/master/docs/Gopkg.toml.md again and I think you're doing it right :)

@k8s-ci-robot k8s-ci-robot merged commit efef780 into kserve:master Apr 5, 2019
@yuzisun yuzisun deleted the dep_update branch April 5, 2019 17:29
@pugangxa pugangxa mentioned this pull request Nov 5, 2019
Merged
ellistarn pushed a commit to ellistarn/kfserving that referenced this pull request Jul 28, 2020
@yuzisun @k8s-ci-robot
Update dep with Knative dependency and add knative service placeholder (
4b72042 
kserve#10)

* update dep dependency for knative

* watch knative service and generate rbac
@kd303 kd303 mentioned this pull request Jan 6, 2021
Closed
@prgawade prgawade mentioned this pull request Jan 22, 2021
Closed
Surya-smart619 pushed a commit to Surya-smart619/kserve that referenced this pull request May 11, 2022
@yuzisun
Merge pull request kserve#22 from Suresh-Nakkeran/api-reference-doc
7c13f2a 
inferenceservice api reference doc kserve#10
rafvasq pushed a commit to rafvasq/kserve that referenced this pull request Jul 21, 2023
@pvaneck
chore: Update GH Action workflows (kserve#10)
e1b50f3 
Both workflows for PRs and pushes were cleaned up. On a push (which
includes when PRS merge), the code base is linted and tested first
before building and publishing.
terrytangyuan pushed a commit to terrytangyuan/kserve that referenced this pull request May 13, 2024
@vaibhavjainwiz
Merge pull request kserve#10 from vajain-rhods/update_py-skp
c3be733 
Downgrade py-spy to "0.3.12"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellistarn ellistarn ellistarn left review comments

@ukclivecox ukclivecox Awaiting requested review from ukclivecox

Assignees

@ellistarn ellistarn

Labels
approved lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yuzisun @ellistarn @k8s-ci-robot