New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs/custom domain #1036
Docs/custom domain #1036
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Hi @adamkgray. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@googlebot I signed it! |
/assign @animeshsingh |
/lgtm |
/ok-to-test |
/retest |
3 similar comments
/retest |
/retest |
/retest |
@adamkgray: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Tfw you just update the docs but it makes the tests fail. Did i fork the wrong branch? |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yuzisun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@adamkgray Thanks for
No, your PR is all good just we had some gcloud issues lately for the CI. Thanks for the doc contribution @adamkgray, this is really helpful! |
Update documentation related to setting up a custom domain for kfserving.
I made these changes after a conversation in the kfserving slack channel. I want to help clarify use-cases and motivations for future users. It personally took me a long time to find and apply this example doc.
So hopefully by updating the wording and adding some implementation context, others will be able to more quickly find and use these snippets.
Fixes:
kf-serving.yml
that breaks the intended functionalityRelease note: