Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs/custom domain #1036

Merged
merged 4 commits into from Aug 30, 2020
Merged

Docs/custom domain #1036

merged 4 commits into from Aug 30, 2020

Conversation

adamkgray
Copy link
Contributor

@adamkgray adamkgray commented Aug 21, 2020

Update documentation related to setting up a custom domain for kfserving.

I made these changes after a conversation in the kfserving slack channel. I want to help clarify use-cases and motivations for future users. It personally took me a long time to find and apply this example doc.

So hopefully by updating the wording and adding some implementation context, others will be able to more quickly find and use these snippets.

Fixes:

  • Remove path constraint from kf-serving.yml that breaks the intended functionality
  • Update the verify example
  • Add AWS example using ALB Ingress Controller

Release note:


@google-cla
Copy link

google-cla bot commented Aug 21, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@kubeflow-bot
Copy link

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Hi @adamkgray. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adamkgray
Copy link
Contributor Author

@googlebot I signed it!

@adamkgray
Copy link
Contributor Author

/assign @animeshsingh

@pugangxa
Copy link
Contributor

/lgtm

@yuzisun
Copy link
Member

yuzisun commented Aug 27, 2020

/ok-to-test

@yuzisun
Copy link
Member

yuzisun commented Aug 28, 2020

/retest

3 similar comments
@yuzisun
Copy link
Member

yuzisun commented Aug 28, 2020

/retest

@yuzisun
Copy link
Member

yuzisun commented Aug 28, 2020

/retest

@yuzisun
Copy link
Member

yuzisun commented Aug 29, 2020

/retest

@k8s-ci-robot
Copy link
Contributor

@adamkgray: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
kubeflow-kfserving-presubmit fa407e4 link /test kubeflow-kfserving-presubmit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@adamkgray
Copy link
Contributor Author

Tfw you just update the docs but it makes the tests fail. Did i fork the wrong branch?

@yuzisun
Copy link
Member

yuzisun commented Aug 29, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yuzisun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yuzisun
Copy link
Member

yuzisun commented Aug 30, 2020

@adamkgray Thanks for

Tfw you just update the docs but it makes the tests fail. Did i fork the wrong branch?

No, your PR is all good just we had some gcloud issues lately for the CI.

Thanks for the doc contribution @adamkgray, this is really helpful!

@yuzisun yuzisun merged commit 949e8ef into kserve:master Aug 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants