New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use github action for kfserving controller tests #1056
Conversation
/lgtm |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excited to see this in action.
Can you run docker containers w/ github actions?
I feel like the workflow should be
Github Action -> Kick off tekton build in build fleet -> Return
@@ -184,6 +184,19 @@ docker-build-storageInitializer: | |||
docker-push-storageInitializer: docker-build-storageInitializer | |||
docker push ${KO_DOCKER_REPO}/${STORAGE_INIT_IMG} | |||
|
|||
kubebuilder: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need kb as a dependency? This is for generating controllers, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is for make test
which requires local apiserver/etcd which is installed part of kubebuilder
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ellistarn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: