Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GCS support and tests #1105

Merged
merged 4 commits into from
Jan 15, 2021
Merged

Add GCS support and tests #1105

merged 4 commits into from
Jan 15, 2021

Commits on Jan 15, 2021

  1. Adding in GCS support 

    Adding in testing

Removing mockapi and using google-cloud-go-testing instead, removing unnecessary methods, cleaning up code

Changing back dockerfile name

Rebasing on master

Fixing import statement

Reverting kfstorage rename to storage, changing gcs import

Fixing import statement

Changing import in test

Combining tests into watcher_test, putting mocks into a testutils package

Removing unnecessary suite run, renaming testutils to mocks

Adding more test cases, accounting for lack of model name in passed in storageURI

Changing iterator retrieval logic

Rebasing and cleaning code
    michael.szacillo committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    4599d45 View commit details
    Browse the repository at this point in the history

  2. Returning a warning if queried object doesn't exist in bucket, resolv… 

    …ing test
    michael.szacillo committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    8360dcd View commit details
    Browse the repository at this point in the history

  3. Rebasing, removing unused import, refactoring

    michael.szacillo committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    6cbe8a4 View commit details
    Browse the repository at this point in the history

  4. Adding missing parameter to NewWatcher call

    michael.szacillo committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    085c459 View commit details
    Browse the repository at this point in the history