New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add torchserve custom server #1156
Feature: Add torchserve custom server #1156
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Hi @jagadeeshi2i. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@googlebot I signed it!
…On Fri, Oct 23, 2020 at 8:27 PM google-cla[bot] ***@***.***> wrote:
Thanks for your pull request. It looks like this may be your first
contribution to a Google open source project (if not, look below for help).
Before we can look at your pull request, you'll need to sign a Contributor
License Agreement (CLA).
📝 *Please visit https://cla.developers.google.com/
<https://cla.developers.google.com/> to sign.*
Once you've signed (or fixed any issues), please reply here with @googlebot
I signed it! and we'll verify it.
------------------------------
What to do if you already signed the CLA Individual signers
- It's possible we don't have your GitHub username or you're using a
different email address on your commit. Check your existing CLA data
<https://cla.developers.google.com/clas> and verify that your email is
set on your git commits
<https://help.github.com/articles/setting-your-email-in-git/>.
Corporate signers
- Your company has a Point of Contact who decides which employees are
authorized to participate. Ask your POC to be added to the group of
authorized contributors. If you don't know who your Point of Contact is,
direct the Google project maintainer to go/cla#troubleshoot (Public
version <https://opensource.google/docs/cla/#troubleshoot>).
- The email used to register you as an authorized contributor must be
the email used for the Git commit. Check your existing CLA data
<https://cla.developers.google.com/clas> and verify that your email is
set on your git commits
<https://help.github.com/articles/setting-your-email-in-git/>.
- The email used to register you as an authorized contributor must
also be attached to your GitHub account
<https://github.com/settings/emails>.
ℹ️ *Googlers: Go here
<https://goto.google.com/prinfo/https%3A%2F%2Fgithub.com%2Fkubeflow%2Fkfserving%2Fpull%2F1156>
for more info*.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1156 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALB6LAABCKTZQ74T5QL7VPTSMGKUXANCNFSM4S4VKH7Q>
.
--
*Jagadeesh J*
Senior Software Engineer
Ideas2IT Technologies
M: +91-809-87-01730
<https://www.ideas2it.com/>
*YourStory <https://yourstory.com/2017/12/when-my-staff-decides-on-a-midweek-leave-i-am-okay-with-it-says-ideas2it-founder-murali-vivekanandan/>
*|
* Meetup <https://www.meetup.com/Chennai-Data-Science-and-ML-Club/> |
Facebook <https://www.facebook.com/Ideas2IT/> | Linkedin
<https://www.linkedin.com/company/ideas2it/> | Instagram
<https://www.instagram.com/ideas2it/?hl=en> | Github
<https://github.com/Ideas2IT>*
DISCLAIMER:
This e-mail and any files transmitted with it are for the sole use of
the intended recipient(s) and may contain confidential and privileged
information. If you are not the intended recipient(s), please reply to
the sender and destroy all copies of the original message. Any review,
use, disclosure, dissemination, forwarding, printing or copying of
this email, and/or any action taken in reliance on the contents of
this e-mail is strictly prohibited and may be unlawful. Opinions,
conclusions and other information in this message that do not related
to official business of the company shall be understood to be neither
given nor endorsed by Ideas2IT Technology Services Private Limited.
Any information contained in this email, when addressed to Clients is
subject to the terms and conditions in governing the client contract.
|
/ok-to-test |
- fix dockerfile - fix Readme
…rage" This reverts commit af1da75.
@jagadeeshi2i: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
- Dockerfile - Readme - lint error
/retest |
1 similar comment
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work always, Thanks @jagadeeshi2i !
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jagadeeshi2i, yuzisun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jagadeeshi2i: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What this PR does / why we need it:
Adds torchserve custom model server sample in v1beta1 version.
Which issue(s) this PR fixes
Fixes #1178
Special notes for your reviewer:
Release note: