Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add torchserve custom server #1156

Merged

Conversation

jagadeeshi2i
Copy link
Member

@jagadeeshi2i jagadeeshi2i commented Oct 23, 2020

What this PR does / why we need it:
Adds torchserve custom model server sample in v1beta1 version.

Which issue(s) this PR fixes

Fixes #1178

Special notes for your reviewer:

Release note:

Adds torchserve cusom model server sample in v1beta1 version.

@google-cla
Copy link

google-cla bot commented Oct 23, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@k8s-ci-robot
Copy link
Contributor

Hi @jagadeeshi2i. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubeflow-bot
Copy link

This change is Reviewable

@jagadeeshi2i
Copy link
Member Author

jagadeeshi2i commented Oct 23, 2020 via email

@yuzisun
Copy link
Member

yuzisun commented Oct 26, 2020

/ok-to-test

@k8s-ci-robot
Copy link
Contributor

@jagadeeshi2i: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
kubeflow-kfserving-presubmit 500fc05 link /test kubeflow-kfserving-presubmit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

 - Dockerfile
 - Readme
 - lint error
@jagadeeshi2i jagadeeshi2i changed the title Feature: Add torchserve custom model sample Feature: Add torchserve custom server Nov 5, 2020
@yuzisun
Copy link
Member

yuzisun commented Nov 5, 2020

/retest

1 similar comment
@yuzisun
Copy link
Member

yuzisun commented Nov 7, 2020

/retest

docs/samples/custom/torchserve/gpu.yaml Outdated Show resolved Hide resolved
docs/samples/custom/torchserve/torchserve-custom.yaml Outdated Show resolved Hide resolved
docs/samples/custom/torchserve/canary.yaml Outdated Show resolved Hide resolved
docs/samples/custom/torchserve/autoscale.yaml Outdated Show resolved Hide resolved
docs/samples/custom/torchserve/torchserve-image/README.md Outdated Show resolved Hide resolved
docs/samples/custom/torchserve/docs/autoscaling.md Outdated Show resolved Hide resolved
docs/samples/custom/torchserve/README.md Outdated Show resolved Hide resolved
docs/samples/custom/torchserve/gpu.yaml Outdated Show resolved Hide resolved
docs/samples/custom/torchserve/docs/canary.md Show resolved Hide resolved
docs/samples/custom/torchserve/gpu.yaml Outdated Show resolved Hide resolved
docs/samples/custom/torchserve/docs/canary.md Outdated Show resolved Hide resolved
docs/samples/custom/torchserve/docs/canary.md Outdated Show resolved Hide resolved
Copy link
Member

@yuzisun yuzisun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work always, Thanks @jagadeeshi2i !

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jagadeeshi2i, yuzisun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aws-kf-ci-bot
Copy link
Contributor

@jagadeeshi2i: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
kubeflow-kfserving-presubmit-e2e 01e5930 link /test kubeflow-kfserving-presubmit-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add TorchServe as a CustomServer for KFServing
6 participants