Update k8s libraries to 0.19.2 #1305

ivan-valkov · 2021-01-18T13:07:17Z

What this PR does / why we need it:
This PR updates our k8s dependencies to 0.19. It will provide compatibility with 0.19 k8s versions and allow projects using kfserving internally to have an easier migration to 0.19.
Only a small modification was needed to be able to use 0.19 - updating the copy of podSpec we have.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1293

Special notes for your reviewer:

I have tested this change by running make test. All the formatting changes were made from running make test.

Release note:

NONE

google-cla · 2021-01-18T13:07:23Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

aws-kf-ci-bot · 2021-01-18T13:07:27Z

Hi @ivan-valkov. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ivan-valkov · 2021-01-18T13:07:39Z

docs/samples/v1alpha2/custom/grpc-server/client/client.go

@@ -8,7 +8,7 @@ import (
 	"log"
 	"time"

-	pb "helloworld/proto"
+	pb "github.com/kubeflow/kfserving/docs/samples/v1alpha2/custom/grpc-server/proto"


had to update this to make go mod happy

adriangonz

Hey @ivan-valkov , changes look good! 👍 Do you foresee any backwards compatibility issues running in older clusters?

ivan-valkov · 2021-01-18T13:27:00Z

Hey @ivan-valkov , changes look good! Do you foresee any backwards compatibility issues running in older clusters?

Good question @adriangonz , I do not expect there to be any issues, but let me test some basic workflows on a k8s 1.15 cluster and I will get back to you.

ivan-valkov · 2021-01-18T17:24:13Z

Hey @ivan-valkov , changes look good! Do you foresee any backwards compatibility issues running in older clusters?

Good question @adriangonz , I do not expect there to be any issues, but let me test some basic workflows on a k8s 1.15 cluster and I will get back to you.

I tested on a kind cluster and creation and deletion work fine. I think there won't be backwards compatibility issues with updating these libs @adriangonz

yuzisun · 2021-01-18T18:20:11Z

@ivan-valkov can you help sign the cla?

yuzisun · 2021-01-18T19:55:27Z

go.mod

+	k8s.io/kubelet => k8s.io/kubelet v0.19.2
+	k8s.io/legacy-cloud-providers => k8s.io/legacy-cloud-providers v0.19.2
+	k8s.io/metrics => k8s.io/metrics v0.19.2
+	k8s.io/sample-apiserver => k8s.io/sample-apiserver v0.19.2
 	k8s.io/test-infra => k8s.io/test-infra v0.0.0-20200803112140-d8aa4e063646
 	k8s.io/utils => k8s.io/utils v0.0.0-20200324210504-a9aa75ae1b89
 	// based on https://github.com/openshift/cluster-ingress-operator/pull/429/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6R34


Can you help remove the following controller-runtime pin and bump up to 0.7.0? I think we no longer need it once move to 1.19.2.

I gave it a try but it turns out we use a bunch of deprecated packages from controller-runtime that are deleted in 0.7.0. These are pkg/runtime/log and pkg/runtime/signals. The issue mentioned in this comment (kubernetes-sigs/controller-runtime#1033) is fixed only from 0.7.0 onwards. I created #1307 to track the migration away from the deprecated packages and the update of this dependency.

ivan-valkov · 2021-01-19T10:22:58Z

@googlebot I signed it!

yuzisun · 2021-01-19T14:10:13Z

/ok-to-test

PatrickXYS · 2021-01-19T23:25:51Z

/test kubeflow-kfserving-presubmit

Test to see if E2E test works fine without Unauthorized issue

ivan-valkov · 2021-01-25T10:21:51Z

Hey, hope you had a good weekend. I resolved a conflict with master and tests seem to be passing. Is there anything else we need to get this one merged @yuzisun @PatrickXYS

PatrickXYS · 2021-01-25T16:47:57Z

/test kubeflow-kfserving-presubmit

PatrickXYS · 2021-01-25T17:56:31Z

FAILED predictor/test_sklearn.py::test_sklearn_v2_kfserving - KeyError: 'outp...

Ref: http://86308603-argo-argo-5ce9-1162466691.us-west-2.elb.amazonaws.com/workflows/kubeflow-test-infra/kubeflow-kfserving-presubmit-e2e-1305-7b34a42-0256-a794?tab=workflow&nodeId=kubeflow-kfserving-presubmit-e2e-1305-7b34a42-0256-a794-4239156108&sidePanel=logs%3Akubeflow-kfserving-presubmit-e2e-1305-7b34a42-0256-a794-4239156108%3Amain

adriangonz · 2021-01-26T09:11:02Z

/test kubeflow-kfserving-presubmit

adriangonz · 2021-01-26T10:28:07Z

/test kubeflow-kfserving-presubmit

Testing to see if the 401 occurs again.

yuzisun · 2021-01-30T14:30:47Z

/retest

PatrickXYS · 2021-02-01T01:20:40Z

/retest

PatrickXYS · 2021-02-01T01:21:00Z

/test ?

aws-kf-ci-bot · 2021-02-01T01:21:06Z

@PatrickXYS: The following commands are available to trigger jobs:

/test kubeflow-kfserving-presubmit

Use /test all to run all jobs.

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

PatrickXYS · 2021-02-01T01:21:13Z

/test kubeflow-kfserving-presubmit

PatrickXYS · 2021-02-01T01:26:11Z

 Failed: cannot unmarshall spec: cannot convert int64 to string

Please rebase master branch to make sure it updates test code

pugangxa · 2021-02-02T07:07:02Z

/retest

pugangxa · 2021-02-02T09:16:31Z

Still Failed: cannot unmarshall spec: cannot convert int64 to string, is there something wrong with the agro workflow?

ivan-valkov · 2021-02-02T10:12:37Z

 Failed: cannot unmarshall spec: cannot convert int64 to string
Please rebase master branch to make sure it updates test code

just rebased on master. Let's retest this :)

ivan-valkov · 2021-02-02T10:12:45Z

/retest

ivan-valkov · 2021-02-02T11:36:13Z

kubeflow-kfserving-presubmit now passes after the rabase - http://prow.kubeflow-testing.com/view/s3/aws-kubeflow-jenkins/pr-logs/pull/kubeflow_kfserving/1305/kubeflow-kfserving-presubmit/1356545934145622016

pugangxa · 2021-02-03T01:55:07Z

/lgtm

yuzisun · 2021-02-03T03:56:57Z

/approve

k8s-ci-robot · 2021-02-03T03:57:03Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivan-valkov, yuzisun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [yuzisun]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* parent a0a52f8 author Manasvi Tickoo <MTICKOO@bloomberg.net> 1611275174 -0500 committer Manasvi Tickoo <MTICKOO@bloomberg.net> 1612370131 -0500 1159 - cloudevent support ofr kfserving PR comments Fix clpudevent headers Add unit test for cloud event messages Add avro unit test Add avro to kfserving requirements.txt PR comments kfserving check ce-contenttyp before unmarshalling Update k8s libraries to 0.19.2 (#1305) * go mod tidy * Update k8s libs to 0.19.2, fix issues, and run make tests * Handle ce to_binary return type wile building resp

k8s-ci-robot requested review from adriangonz and yuzliu January 18, 2021 13:07

aws-kf-ci-bot added the needs-ok-to-test label Jan 18, 2021

k8s-ci-robot added the size/XL label Jan 18, 2021

ivan-valkov commented Jan 18, 2021

View reviewed changes

adriangonz reviewed Jan 18, 2021

View reviewed changes

yuzisun reviewed Jan 18, 2021

View reviewed changes

ivan-valkov mentioned this pull request Jan 19, 2021

Replace deprecated controller-runtime packages #1307

Closed

aws-kf-ci-bot added ok-to-test and removed needs-ok-to-test labels Jan 19, 2021

ivan-valkov force-pushed the update-k8s-0.19.2 branch from 6c0f1c0 to 7b34a42 Compare January 25, 2021 10:15

pugangxa mentioned this pull request Feb 2, 2021

Upgrade controller-runtime to v0.7.0 #1341

Merged

ivan-valkov added 2 commits February 2, 2021 10:11

go mod tidy

b51e423

Update k8s libs to 0.19.2, fix issues, and run make tests

7a3f011

ivan-valkov force-pushed the update-k8s-0.19.2 branch from 7b34a42 to 7a3f011 Compare February 2, 2021 10:11

k8s-ci-robot assigned pugangxa Feb 3, 2021

k8s-ci-robot added the lgtm label Feb 3, 2021

k8s-ci-robot added the approved label Feb 3, 2021

k8s-ci-robot merged commit 722fec1 into kserve:master Feb 3, 2021

ivan-valkov deleted the update-k8s-0.19.2 branch February 3, 2021 08:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update k8s libraries to 0.19.2 #1305

Update k8s libraries to 0.19.2 #1305

ivan-valkov commented Jan 18, 2021

google-cla bot commented Jan 18, 2021

aws-kf-ci-bot commented Jan 18, 2021

ivan-valkov Jan 18, 2021

adriangonz left a comment

ivan-valkov commented Jan 18, 2021

ivan-valkov commented Jan 18, 2021

yuzisun commented Jan 18, 2021

yuzisun Jan 18, 2021

ivan-valkov Jan 19, 2021

ivan-valkov commented Jan 19, 2021

yuzisun commented Jan 19, 2021

PatrickXYS commented Jan 19, 2021

ivan-valkov commented Jan 25, 2021

PatrickXYS commented Jan 25, 2021

PatrickXYS commented Jan 25, 2021

adriangonz commented Jan 26, 2021

adriangonz commented Jan 26, 2021

yuzisun commented Jan 30, 2021

PatrickXYS commented Feb 1, 2021

PatrickXYS commented Feb 1, 2021

aws-kf-ci-bot commented Feb 1, 2021

PatrickXYS commented Feb 1, 2021

PatrickXYS commented Feb 1, 2021

pugangxa commented Feb 2, 2021

pugangxa commented Feb 2, 2021

ivan-valkov commented Feb 2, 2021

ivan-valkov commented Feb 2, 2021

ivan-valkov commented Feb 2, 2021

pugangxa commented Feb 3, 2021

yuzisun commented Feb 3, 2021

k8s-ci-robot commented Feb 3, 2021

Update k8s libraries to 0.19.2 #1305

Update k8s libraries to 0.19.2 #1305

Conversation

ivan-valkov commented Jan 18, 2021

google-cla bot commented Jan 18, 2021

What to do if you already signed the CLA

Individual signers

Corporate signers

aws-kf-ci-bot commented Jan 18, 2021

ivan-valkov Jan 18, 2021

Choose a reason for hiding this comment

adriangonz left a comment

Choose a reason for hiding this comment

ivan-valkov commented Jan 18, 2021

ivan-valkov commented Jan 18, 2021

yuzisun commented Jan 18, 2021

yuzisun Jan 18, 2021

Choose a reason for hiding this comment

ivan-valkov Jan 19, 2021

Choose a reason for hiding this comment

ivan-valkov commented Jan 19, 2021

yuzisun commented Jan 19, 2021

PatrickXYS commented Jan 19, 2021

ivan-valkov commented Jan 25, 2021

PatrickXYS commented Jan 25, 2021

PatrickXYS commented Jan 25, 2021

adriangonz commented Jan 26, 2021

adriangonz commented Jan 26, 2021

yuzisun commented Jan 30, 2021

PatrickXYS commented Feb 1, 2021

PatrickXYS commented Feb 1, 2021

aws-kf-ci-bot commented Feb 1, 2021

PatrickXYS commented Feb 1, 2021

PatrickXYS commented Feb 1, 2021

pugangxa commented Feb 2, 2021

pugangxa commented Feb 2, 2021

ivan-valkov commented Feb 2, 2021

ivan-valkov commented Feb 2, 2021

ivan-valkov commented Feb 2, 2021

pugangxa commented Feb 3, 2021

yuzisun commented Feb 3, 2021

k8s-ci-robot commented Feb 3, 2021