-
Notifications
You must be signed in to change notification settings - Fork 999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent experimental features from being set by default setting multimodelserver flags to false #1375
Conversation
Hi @abchoo. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/LGTM |
@abchoo what happens when user submits trained model when the flag is off? |
@abchoo Can you help regenerate the 0.5 release yaml by running |
/ok-to-test |
/retest |
/retest |
Thanks @abchoo! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abchoo, yuzisun, yuzliu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it: By default the flags in inferenceservice.yaml for SKLearn, XGBoost, LightGMB, and Triton have been set to true which means MMS is enabled without users knowing. We want to prevent this from happening.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: