New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated cert-manager version. #1904
Conversation
Generated kserve install manifests.
Skipping CI for Draft Pull Request. |
@@ -1,14 +1,14 @@ | |||
# The following manifests contain a self-signed issuer CR and a certificate CR. | |||
# More document can be found at https://docs.cert-manager.io | |||
apiVersion: cert-manager.io/v1alpha2 | |||
apiVersion: cert-manager.io/v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you help find out which cert manager version introduces the v1 version? we need to update the doc with the minimum requirement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since version 1.0.0
https://cert-manager.io/docs/release-notes/release-notes-1.0/
I will also test with 1.0 to be sure.
hack/quick_install.sh
Outdated
@@ -32,7 +32,7 @@ done | |||
|
|||
export ISTIO_VERSION=1.9.0 | |||
export KNATIVE_VERSION=v0.22.0 | |||
export KSERVE_VERSION=v0.7.0 | |||
export KSERVE_VERSION=v0.8.0-rc0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep this out, the current plan is to cut 0.8 release early Dec
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyi2it, yuzisun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Updated cert-manager version. Generated kserve install manifests. * Delete kserve.yaml * Delete kserve_kubeflow.yaml * Update quick_install.sh Co-authored-by: Dan Sun <dsun20@bloomberg.net> Signed-off-by: tomcli <tommy.chaoping.li@ibm.com>
Updated cert-manager version.
Generated kserve install manifests.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #1893
Special notes for your reviewer:
Release note: