Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serving Runtime e2e tests #1943

Merged
merged 3 commits into from Dec 29, 2021
Merged

Serving Runtime e2e tests #1943

merged 3 commits into from Dec 29, 2021

Conversation

Suresh-Nakkeran
Copy link
Contributor

@Suresh-Nakkeran Suresh-Nakkeran commented Dec 13, 2021 •
edited by yuzisun

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1924

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

@pvaneck
Copy link
Member

pvaneck commented Dec 13, 2021

Hey @Suresh-Nakkeran, can you split this up into separate PRs to aid in the reviewing process. License header changes can be its own, Python SDK changes can be its own, and E2E tests can be its own.

@Suresh-Nakkeran
Copy link
Contributor Author

Suresh-Nakkeran commented Dec 14, 2021 •
edited

Hey @Suresh-Nakkeran, can you split this up into separate PRs to aid in the reviewing process. License header changes can be its own, Python SDK changes can be its own, and E2E tests can be its own.

@pvaneck License header changes is part of python sdk update. I will split this PR into 2, one is python sdk update and another one for runtime e2e tests.

@pvaneck
Copy link
Member

pvaneck commented Dec 15, 2021

This PR is still showing the python sdk and license header changes. Can you update this branch so only the e2e changes are committed?

@Suresh-Nakkeran Suresh-Nakkeran force-pushed the runtime-e2e-tests branch 4 times, most recently from 0b54f84 to 42cfaba Compare December 22, 2021 11:34
@Suresh-Nakkeran
Copy link
Contributor Author

/test kubeflow-kserve-presubmit

@kserve-oss-bot
Copy link
Collaborator

@Suresh-Nakkeran: No presubmit jobs available for kserve/kserve@master

In response to this:

/test kubeflow-kserve-presubmit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Suresh-Nakkeran
Copy link
Contributor Author

/test kubeflow-kserve-presubmit

@kserve-oss-bot
Copy link
Collaborator

@Suresh-Nakkeran: No presubmit jobs available for kserve/kserve@master

In response to this:

/test kubeflow-kserve-presubmit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Suresh-Nakkeran Suresh-Nakkeran force-pushed the runtime-e2e-tests branch 3 times, most recently from d258f69 to eb8fb8b Compare December 23, 2021 16:49
@yuzisun
Copy link
Member

yuzisun commented Dec 24, 2021

/retest

@yuzisun yuzisun changed the title Runtime e2e tests Serving Runtime e2e tests Dec 24, 2021
@yuzisun
Copy link
Member

yuzisun commented Dec 24, 2021

/retest

@Suresh-Nakkeran
added e2e tests for servingruntimes
6199035 
Signed-off-by: Suresh Nakkeran <suresh.n@ideas2it.com>
@Suresh-Nakkeran
Copy link
Contributor Author

/retest

@Suresh-Nakkeran Suresh-Nakkeran force-pushed the runtime-e2e-tests branch 2 times, most recently from 402a913 to 664f0e6 Compare December 28, 2021 15:26
@Suresh-Nakkeran
move kserve client into test func
668b7f9 
Signed-off-by: Suresh Nakkeran <suresh.n@ideas2it.com>
yuzisun
yuzisun reviewed Dec 28, 2021
View reviewed changes
test/e2e/predictor/test_triton.py Outdated Show resolved Hide resolved
test/e2e/predictor/test_canary.py Show resolved Hide resolved
@Suresh-Nakkeran
update transformer image
b15a9e3 
Signed-off-by: Suresh Nakkeran <suresh.n@ideas2it.com>
@Suresh-Nakkeran
Copy link
Contributor Author

/retest

@yuzisun
Copy link
Member

yuzisun commented Dec 29, 2021

/lgtm
/approve

@kserve-oss-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Suresh-Nakkeran, yuzisun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kserve-oss-bot kserve-oss-bot merged commit c407b2d into kserve:master Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuzisun yuzisun yuzisun left review comments

@adriangonz adriangonz Awaiting requested review from adriangonz

@yuzliu yuzliu Awaiting requested review from yuzliu

Assignees

@yuzisun yuzisun

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Follow up work for ServingRuntime support
4 participants
@Suresh-Nakkeran @pvaneck @kserve-oss-bot @yuzisun