Rename KF prefixed classes #1951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Mark Winter <mark.winter@navercorp.com>
markwinter
force-pushed
the
rename-kf-classes
branch
from
7e3feed
to
b9bf6aa
Compare
Signed-off-by: Mark Winter <mark.winter@navercorp.com>
Signed-off-by: Mark Winter <mark.winter@navercorp.com>
Signed-off-by: Mark Winter <mark.winter@navercorp.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
markwinter
added a commit
to markwinter/kserve
that referenced
this pull request
Dec 20, 2021
h5py 2.9 is not compatible with the tensorflow version required by alibiexplainer. Should just use the version pulled in by alibiexplainer kserve#1951 (comment)
markwinter
added a commit
to markwinter/kserve
that referenced
this pull request
Dec 20, 2021
h5py 2.9 is not compatible with the tensorflow version required by alibiexplainer. Should just use the version pulled in by alibiexplainer kserve#1951 (comment) Signed-off-by: Mark Edward Winter <wintermarkedward@gmail.com>
This comment has been minimized.
This comment has been minimized.
yuzisun
pushed a commit
that referenced
this pull request
Dec 20, 2021
h5py 2.9 is not compatible with the tensorflow version required by alibiexplainer. Should just use the version pulled in by alibiexplainer #1951 (comment) Signed-off-by: Mark Edward Winter <wintermarkedward@gmail.com>
|
This is ready to be reviewed now. Need to update all documentation and examples after this |
|
@markwinter Can you help rebase from master to pick up the e2e tests fix ? |
|
@yuzisun Done |
|
Thanks @markwinter! /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markwinter, yuzisun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Dec 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
KFModel->ModelKFServer->ModelServerKFModelRepository->ModelRepositorykserve.api.kf_serving_client->kserve.api.kserve_clientkserve.api.kf_serving_watch->kserve.api.watchAlso updated some comments that said KFServing still
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1947
Release note: