Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Upgrade Golang to 1.17 #1962

Merged
merged 1 commit into from Dec 25, 2021
Merged

Chore: Upgrade Golang to 1.17 #1962

merged 1 commit into from Dec 25, 2021

Conversation

haoxins
Copy link
Contributor

@haoxins haoxins commented Dec 25, 2021 •
edited by yuzisun

Related to #1960

Upgrade the Golang mod and base Docker Image to 1.17

@aws-kf-ci-bot
Copy link
Contributor

Hi @haoxins. Thanks for your PR.

I'm waiting for a kserve member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@haoxins
Chore: Upgrade Golang to 1.17
400fb55 
Signed-off-by: Hao Xin <haoxinst@gmail.com>
haoxins
haoxins commented Dec 25, 2021
View reviewed changes
test/workflows/components/workflows.libsonnet
@@ -46,7 +46,7 @@
local pylintSrcDir = srcDir + "/python";
local kanikoExecutorImage = "gcr.io/kaniko-project/executor:v1.0.0";
local testWorkerImage = "public.ecr.aws/j1r0q0g6/kubeflow-testing:latest";
local golangImage = "golang:1.9.4-stretch";
local golangImage = "golang:1.17-stretch";
// TODO(jose5918) Build our own helm image
local pythonImage = "python:3.6-jessie";
local helmImage = "volumecontroller/golang:1.9.2";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image seems too old.

Updated 4 years ago

@yuzisun
Copy link
Member

yuzisun commented Dec 25, 2021

/ok-to-test

@yuzisun
Copy link
Member

yuzisun commented Dec 25, 2021

thanks @haoxins !

/lgtm
/approve

@kserve-oss-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haoxins, yuzisun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kserve-oss-bot kserve-oss-bot merged commit aaee2ff into kserve:master Dec 25, 2021
@haoxins haoxins deleted the chore-go-mod-1.17 branch December 26, 2021 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pugangxa pugangxa Awaiting requested review from pugangxa

@pvaneck pvaneck Awaiting requested review from pvaneck

Assignees

@yuzisun yuzisun

Labels
approved lgtm ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@haoxins @aws-kf-ci-bot @yuzisun @kserve-oss-bot