fix: allow to set worker count more than 1 #1984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuzisun
reviewed
Jan 11, 2022
python/kserve/kserve/model_server.py
Outdated
| logging.info(f"Setting asyncio max_workers as {self.max_asyncio_workers}") | ||
| asyncio.get_event_loop().set_default_executor( | ||
| concurrent.futures.ThreadPoolExecutor(max_workers=self.max_asyncio_workers)) | ||
| if self.workers == 1: |
There was a problem hiding this comment.
@Suresh-Nakkeran just saw this comment, can you try removing worker check and moving the asyncio initialization code after the "fork"(line131) see if multi-processing works .
There was a problem hiding this comment.
you're right @yuzisun . multi-processing is working by moving initialization code after starting http server.
Signed-off-by: Suresh Nakkeran <suresh.n@ideas2it.com>
Suresh-Nakkeran
force-pushed
the
multi-worker-support
branch
from
034e94b
to
cd16a72
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Suresh-Nakkeran, yuzisun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
plankthom
added a commit
to waylayio/kfserving
that referenced
this pull request
Aug 24, 2022
backports kserve#1984
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
according to tornadoweb/tornado#2426 (comment), the async io initialization code should be done after the "fork".
fixes #1759