Add install script for KServe and ModelMesh #2032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/restest |
|
/retest |
pvaneck
reviewed
Feb 5, 2022
hack/install_kserve_mm.sh
Outdated
| if [[ ! -z $user_ns_array ]]; then | ||
| for USER_NS in "${user_ns_array[@]}"; do | ||
| kubectl create ns ${USER_NS} || true | ||
| echo "Installing ModelMesh in namespace: ${USER_NS}..." |
There was a problem hiding this comment.
nit: Maybe "Enabling ModelMesh for namespace:" would be more accurate?
hack/install_kserve_mm.sh
Outdated
|
|
||
| kubectl create ns ${CTLR_NS} || true | ||
| cd "${C_DIR}/modelmesh-serving" | ||
| ./scripts/install.sh -n ${CTLR_NS} --quickstart --dev-mode-logging |
There was a problem hiding this comment.
Wondering if dev-mode-logging shouldn't be on by default since there is considerable DEBUG log spam with this enabled.
There was a problem hiding this comment.
Yeah, most people won't care about logging. Just removed it.
Add install script for KServe and ModelMesh so the user can quickly experiment features provided by two repos. The script will install all prerequisits knative, istio, cert manager, etcd, and minio, and create namespaces when needed. The repo branch variables can be changed to install different versions of KServe and ModelMesh. Signed-off-by: Chin Huang <chhuang@us.ibm.com>
chinhuang007
force-pushed
the
add-all-in-one-install
branch
from
ffb2e2c
to
86a3477
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chinhuang007, yuzisun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
alexagriffith
pushed a commit
to alexagriffith/kserve
that referenced
this pull request
Sep 19, 2022
Add install script for KServe and ModelMesh so the user can quickly experiment features provided by two repos. The script will install all prerequisits knative, istio, cert manager, etcd, and minio, and create namespaces when needed. The repo branch variables can be changed to install different versions of KServe and ModelMesh. Signed-off-by: Chin Huang <chhuang@us.ibm.com> Signed-off-by: alexagriffith <agriffith96@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add install script for KServe and ModelMesh so the user can
quickly experiment features provided by two repos.
The script will install all prerequisits knative, istio, cert
manager, etcd, and minio, and create namespaces when needed.
The repo branch variables can be changed to install different
versions of KServe and ModelMesh.
Signed-off-by: Chin Huang chhuang@us.ibm.com
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: