fix: replace image tag #2074
fix: replace image tag #2074
Conversation
Signed-off-by: Thang Vu <vuminhthang.cm@gmail.com>
|
Hi @ittus. Thanks for your PR. I'm waiting for a kserve member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
| @@ -186,7 +187,12 @@ func ReplacePlaceholders(container *v1.Container, meta metav1.ObjectMeta) error | |||
| func UpdateImageTag(container *v1.Container, runtimeVersion *string, isvcConfig *v1beta1.InferenceServicesConfig) { | |||
| image := container.Image | |||
| if runtimeVersion != nil && len(strings.Split(image, ":")) > 0 { | |||
There was a problem hiding this comment.
I think now the len(strings.Split(image, ":")) > 0 check is redundant and can be removed.
There was a problem hiding this comment.
Thanks. I removed it in cc1397c
|
@ittus Thanks for the fix! a small comment otherwise it looks good. |
Signed-off-by: Thang Vu <vuminhthang.cm@gmail.com>
|
Thanks @ittus for your contribution!! /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ittus, yuzisun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #2068
Type of changes
Please delete options that are not relevant.
Bug fix (non-breaking change which fixes an issue)
Logs
Special notes for your reviewer:
Checklist: