Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix triton + torchscript guidelines to be executable #2091

Merged
merged 3 commits into from
Mar 19, 2022
Merged

Fix triton + torchscript guidelines to be executable #2091

merged 3 commits into from
Mar 19, 2022

Conversation

Curt-Park
Copy link
Contributor

@Curt-Park Curt-Park commented Mar 15, 2022

Signed-off-by: Jinwoo Park (Curt) www.jwpark.co.kr@gmail.com

What this PR does / why we need it:

  • Fixed some misleading hyperlinks
  • Fixed wrong key value (image.json)
  • Fixed curl commands

-> These changes are contained in another PR of KServe Website.

  • Deleted descriptions in README.md by @yuzisun's suggestion

Release note:

Fix Triton with TorchScript guidelines to be executable

Signed-off-by: Jinwoo Park (Curt) <www.jwpark.co.kr@gmail.com>
Signed-off-by: Jinwoo Park (Curt) <www.jwpark.co.kr@gmail.com>
@aws-kf-ci-bot
Copy link
Contributor

Hi @Curt-Park. Thanks for your PR.

I'm waiting for a kserve member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yuzisun
Copy link
Member

yuzisun commented Mar 19, 2022

@Curt-Park We actually have the exactly same tutorial on website, what do you think just delete this and link to the website here?

@Curt-Park
Copy link
Contributor Author

@Curt-Park We actually have the exactly same tutorial on website, what do you think just delete this and link to the website here?

Okay. I will link the website and create a PR on the website repository.

@Curt-Park
Copy link
Contributor Author

Curt-Park commented Mar 19, 2022

@yuzisun I just added a link you mentioned in README.md and didn't change anything else. I think the better way to fix is gathering all of the information for this tutorial in the same place (such as KServe website). However, the related codes have deleted months ago (kserve/website@57c5446) by you. I assume that there is any reason for what you've done.

Please let me know if you have any idea for this.

@yuzisun
Copy link
Member

yuzisun commented Mar 19, 2022

@yuzisun I just added a link you mentioned in README.md and didn't change anything else. I think the better way to fix is gathering all of the information for this tutorial in the same place (such as KServe website). However, the related codes have deleted months ago (kserve/website@57c5446) by you. I assume that there is any reason for what you've done.

Please let me know if you have any idea for this.

@Curt-Park yes the idea is to keep the doc in the website repo and code examples in the kserve repo because some of the examples are used by the e2e tests and it is also easier for contributor to create a PR for new feature with code examples.

@yuzisun
Copy link
Member

yuzisun commented Mar 19, 2022

thanks @Curt-Park !!

/lgtm
/approve

@kserve-oss-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Curt-Park, yuzisun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kserve-oss-bot kserve-oss-bot merged commit 0d62cd4 into kserve:master Mar 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants