-
Notifications
You must be signed in to change notification settings - Fork 982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix triton + torchscript guidelines to be executable #2091
Conversation
Signed-off-by: Jinwoo Park (Curt) <www.jwpark.co.kr@gmail.com>
Signed-off-by: Jinwoo Park (Curt) <www.jwpark.co.kr@gmail.com>
Hi @Curt-Park. Thanks for your PR. I'm waiting for a kserve member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@Curt-Park We actually have the exactly same tutorial on website, what do you think just delete this and link to the website here? |
Okay. I will link the website and create a PR on the website repository. |
Signed-off-by: Jinwoo Park <www.jwpark.co.kr@gmail.com>
@yuzisun I just added a link you mentioned in Please let me know if you have any idea for this. |
@Curt-Park yes the idea is to keep the doc in the |
thanks @Curt-Park !! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Curt-Park, yuzisun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Jinwoo Park (Curt) www.jwpark.co.kr@gmail.com
What this PR does / why we need it:
Fixed some misleading hyperlinksFixed wrong key value (image.json
)Fixed curl commands-> These changes are contained in another PR of KServe Website.
README.md
by @yuzisun's suggestionRelease note: