Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: predict address url on status object #2146

Merged
merged 1 commit into from
Apr 23, 2022

Conversation

Suresh-Nakkeran
Copy link
Contributor

@Suresh-Nakkeran Suresh-Nakkeran commented Apr 18, 2022

Signed-off-by: Suresh Nakkeran suresh.n@ideas2it.com

The inference service address url is updated V2 predict url since ModelSpec GetProtocol function returns protocolV2 by default. This PR is to assign protocol version to inference service based on selected runtime if it is not provided.

Signed-off-by: Suresh Nakkeran <suresh.n@ideas2it.com>
@yuzisun
Copy link
Member

yuzisun commented Apr 23, 2022

Thanks @Suresh-Nakkeran !
/lgtm
/approve

1 similar comment
@yuzisun
Copy link
Member

yuzisun commented Apr 23, 2022

Thanks @Suresh-Nakkeran !
/lgtm
/approve

@kserve-oss-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Suresh-Nakkeran, yuzisun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@kserve-oss-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Suresh-Nakkeran, yuzisun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kserve-oss-bot kserve-oss-bot merged commit f20b9fe into kserve:master Apr 23, 2022
@yuzisun yuzisun changed the title fix: predict address url fix: predict address url on status object Apr 23, 2022
alexagriffith pushed a commit to alexagriffith/kserve that referenced this pull request Sep 19, 2022
Signed-off-by: Suresh Nakkeran <suresh.n@ideas2it.com>
Signed-off-by: alexagriffith <agriffith96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants