Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix downloading model with nested sub folders from gcs #2152

Merged
merged 1 commit into from
Apr 25, 2022
Merged

Fix downloading model with nested sub folders from gcs #2152

merged 1 commit into from
Apr 25, 2022

Conversation

andyi2it
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #817

Type of changes
Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Feature/Issue validation/testing:

Please describe the tests that you ran to verify your changes and relevent result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Created a storage bucket in GCP and verified if its working when the model is uploaded using gui.

  • Verified regular model uploads are being pulled as exepected

  • Logs

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

NONE

@andyi2it
Fix downloading model with nested sub folders from gcs kserve#817
aa45aa6 
* Fixes kserve#817

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
@aws-kf-ci-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@andyi2it
Copy link
Contributor Author

/test all

@kserve-oss-bot
Copy link
Collaborator

@andyi2it: No presubmit jobs available for kserve/kserve@master

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andyi2it andyi2it marked this pull request as ready for review April 22, 2022 05:57
@yuzisun
Copy link
Member

yuzisun commented Apr 25, 2022

Thanks @andyi2it !

/lgtm
/approve

@kserve-oss-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyi2it, yuzisun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kserve-oss-bot kserve-oss-bot merged commit 7962f1c into kserve:master Apr 25, 2022
@yuzisun yuzisun mentioned this pull request Apr 25, 2022
Closed
alexagriffith pushed a commit to alexagriffith/kserve that referenced this pull request Sep 19, 2022
@andyi2it @alexagriffith
Fix downloading model with nested sub folders from gcs kserve#817 (ks…
ab30762 
…erve#2152)

* Fixes kserve#817

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
Signed-off-by: alexagriffith <agriffith96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriangonz adriangonz Awaiting requested review from adriangonz

@pvaneck pvaneck Awaiting requested review from pvaneck

Assignees

@yuzisun yuzisun

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with model downloading from Google Storage when model is in subdirectory
4 participants
@andyi2it @aws-kf-ci-bot @kserve-oss-bot @yuzisun