Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Infer proto docs to mention BFloat16 type #2159

Merged
merged 1 commit into from
Apr 28, 2022

Conversation

rmccorm4
Copy link
Contributor

What this PR does / why we need it:

Adds mention of BFloat16 (BF16) type to the Infer API, similarly handled as FP16. Triton Inference Server is adding TYPE_BF16 support and we want to keep parity with the KServe docs: triton-inference-server/common#49

@aws-kf-ci-bot
Copy link
Contributor

Hi @rmccorm4. Thanks for your PR.

I'm waiting for a kserve member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Ryan McCormick <rmccormick@nvidia.com>
@deadeyegoodwin
Copy link
Contributor

@yuzisun This looks good to me.

@yuzisun
Copy link
Member

yuzisun commented Apr 27, 2022

/ok-to-test

@yuzisun
Copy link
Member

yuzisun commented Apr 28, 2022

/lgtm
/approve

@kserve-oss-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rmccorm4, yuzisun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kserve-oss-bot kserve-oss-bot merged commit 3dc5bfb into kserve:master Apr 28, 2022
alexagriffith pushed a commit to alexagriffith/kserve that referenced this pull request Sep 19, 2022
Signed-off-by: Ryan McCormick <rmccormick@nvidia.com>
Signed-off-by: alexagriffith <agriffith96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants