Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete only the trainedmodel in the namespace where the isvc #2166

Merged
merged 1 commit into from
May 1, 2022
Merged

Delete only the trainedmodel in the namespace where the isvc #2166

merged 1 commit into from
May 1, 2022

Conversation

hehe04
Copy link
Contributor

@hehe04 hehe04 commented May 1, 2022

Signed-off-by: hehe04 hehe04@qq.com

What this PR does / why we need it:

Delete only the trainedmodel in the namespace where the isvc

Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2163

[*] Bug fix (non-breaking change which fixes an issue)

@aws-kf-ci-bot
Copy link
Contributor

Hi @hehe04. Thanks for your PR.

I'm waiting for a kserve member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hehe04 hehe04 mentioned this pull request May 1, 2022
Closed
@yuzisun
Copy link
Member

yuzisun commented May 1, 2022

/ok-to-test

@yuzisun
Copy link
Member

yuzisun commented May 1, 2022

/ok-to-test

@yuzisun
Copy link
Member

yuzisun commented May 1, 2022

Thanks @hehe04 for the fix! Nice finding!

/lgtm
/approve

@kserve-oss-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hehe04, yuzisun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kserve-oss-bot kserve-oss-bot merged commit befef6d into kserve:master May 1, 2022
alexagriffith pushed a commit to alexagriffith/kserve that referenced this pull request Sep 19, 2022
@hehe04 @alexagriffith
Delete only the trainedmodel in the namespace where the isvc (kserve#…
d43a80a 
…2166)

Signed-off-by: hehe04 <hehe04@qq.com>
Signed-off-by: alexagriffith <agriffith96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Iamlovingit Iamlovingit Awaiting requested review from Iamlovingit

@theofpa theofpa Awaiting requested review from theofpa

Assignees

@yuzisun yuzisun

Labels
approved lgtm ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When a isvc is deleted, trained model of other namespaces are cleaned up
4 participants
@hehe04 @aws-kf-ci-bot @yuzisun @kserve-oss-bot