-
Notifications
You must be signed in to change notification settings - Fork 982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Azure file share support #2180
Conversation
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
Signed-off-by: Suresh-Nakkeran <suresh.n@ideas2it.com>
5d6011f
to
32fe085
Compare
/retest |
this PR adds the commits on top of https://github.com/kserve/kserve/pull/1985/files |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Suresh-Nakkeran, yuzisun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Add support to Azure file share Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com> * Add test cases for Azure file share support Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com> * Use account access key auth for Azure file storage Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com> * Upgrade azure storage file share version Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com> * Pass Azure access key to storage initializer Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com> * Add separate function to build storage access key Signed-off-by: Suresh-Nakkeran <suresh.n@ideas2it.com> Co-authored-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com> Signed-off-by: alexagriffith <agriffith96@gmail.com>
This PR has changes to support Azure File Share Storage. I added review comment changes on top @laozc PR.
Release note: