Publish helm chart as release asset

[ddelange]

What this PR does / why we need it:

Allow installing the helm chart without the user having to clone, nor kserve having to set up a helm repository.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2188

Type of changes
Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

Feature/Issue validation/testing:

Please describe the tests that you ran to verify your changes and relevent result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

• Workflow succeeded https://github.com/ddelange/kserve/runs/6525109187?check_suite_focus=true

• Asset uploaded https://github.com/ddelange/kserve/releases/tag/v0.8.0-helm

• Logs

Special notes for your reviewer:

1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Checklist:

• Have you added unit/e2e tests that prove your fix is effective or that this feature works?
• Has code been commented, particularly in hard-to-understand areas?
• Have you made corresponding changes to the documentation?

Release note:

The kserve helm chart has moved to `charts/kserve` and is now packaged and uploaded as a GitHub release asset for every (pre)release. Its URL can be directly passed to the `helm install` command.

[aws-kf-ci-bot]

Hi @ddelange. Thanks for your PR.

I'm waiting for a kserve member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[yuzisun]

@ddelange Thanks for the work with helm! My question is that currently crd is part of one helm chart, as far as I know when we upgrade the chart helm does not update the crd if anything is changed in this case. Should we create a separate chart for crd as helm recommended?

[ddelange]

Oh interesting, I didn't know! I'm guessing that can be a separate issue, this workflow will attempt to helm package any folder under the charts/ path and uploads the archives as separate release assets.

[ddelange]

Indeed looks like istio also splits it up! https://istio.io/latest/docs/setup/install/helm/#installation-steps

[yuzisun]

Indeed looks like istio also splits it up! https://istio.io/latest/docs/setup/install/helm/#installation-steps

yes let's split the crd out then.

[ddelange]

I can give it a shot. Should it be a separate PR? If yes, should it be merged before this one?

[yuzisun]

I can give it a shot. Should it be a separate PR? If yes, should it be merged before this one?

Yes we can merge this one first, thanks!

[ddelange]

@yuzisun I rebased my commit on latest master, in the hope that the flakey (?) test will pass this time 🤞

[ddelange]

@yuzisun could you trigger CI for this PR?

[yuzisun]

/ok-to-test

[yuzisun]

@yuzisun could you trigger CI for this PR?

@ddelange done, can you help rebase and resolve the conflict ?

[ddelange]

@yuzisun pushed, there was no conflict according to git :)

[yuzisun]

Thanks @ddelange! will test out this with the 0.9.0-rc0 release.

/lgtm
/approve

[kserve-oss-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ddelange, yuzisun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [yuzisun]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment