Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix controller manager image patch in CI #2199

Merged
merged 2 commits into from
May 27, 2022
Merged

Fix controller manager image patch in CI #2199

merged 2 commits into from
May 27, 2022

Conversation

yuzisun
Copy link
Member

@yuzisun yuzisun commented May 27, 2022 •
edited

What this PR does / why we need it:
This is the fix for previous controller manager HA PR #2010 which missed changing the statefulset to deployment in CI overlay, so controller changes in PR were not tested.

Also removes the CI actions for deprecated pytorchserver.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Type of changes
Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

@kserve-oss-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yuzisun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yuzisun
Fix controller manager image patch in CI
4b78ead 
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
@yuzisun
remove pytorchserver github actions
f0d76ec 
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
@andyi2it
Copy link
Contributor

/lgtm

@yuzisun
Copy link
Member Author

yuzisun commented May 27, 2022

/test kubeflow-kserve-presubmit

@kserve-oss-bot
Copy link
Collaborator

@yuzisun: No presubmit jobs available for kserve/kserve@master

In response to this:

/test kubeflow-kserve-presubmit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yuzisun
Copy link
Member Author

yuzisun commented May 27, 2022

/retest kubeflow-kserve-presubmit

@kserve-oss-bot
Copy link
Collaborator

@yuzisun: No presubmit jobs available for kserve/kserve@master

In response to this:

/retest kubeflow-kserve-presubmit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yuzisun yuzisun merged commit 58d215e into kserve:master May 27, 2022
alexagriffith pushed a commit to alexagriffith/kserve that referenced this pull request Sep 19, 2022
@yuzisun @alexagriffith
Fix controller manager image patch in CI (kserve#2199)
0437722 
* Fix controller manager image patch in CI

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

* remove pytorchserver github actions

Signed-off-by: Dan Sun <dsun20@bloomberg.net>
Signed-off-by: alexagriffith <agriffith96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tomcli Tomcli Awaiting requested review from Tomcli

@yuzliu yuzliu Awaiting requested review from yuzliu

Assignees

@andyi2it andyi2it

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yuzisun @kserve-oss-bot @andyi2it