Added a specific version for protobuf #2201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a specific version for protobuf in requirements.txt Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyi2it, yuzisun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
yuzisun
pushed a commit
to yuzisun/kserve
that referenced
this pull request
Jul 20, 2022
Added a specific version for protobuf in requirements.txt Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
yuzisun
pushed a commit
to yuzisun/kserve
that referenced
this pull request
Jul 20, 2022
Added a specific version for protobuf in requirements.txt Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
yuzisun
pushed a commit
to yuzisun/kserve
that referenced
this pull request
Jul 20, 2022
Added a specific version for protobuf in requirements.txt Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> Signed-off-by: Dan Sun <dsun20@bloomberg.net>
yuzisun
pushed a commit
to yuzisun/kserve
that referenced
this pull request
Jul 20, 2022
Added a specific version for protobuf in requirements.txt Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> Signed-off-by: Dan Sun <dsun20@bloomberg.net>
kserve-oss-bot
pushed a commit
that referenced
this pull request
Jul 20, 2022
* Added a specific version for protobuf (#2201) Added a specific version for protobuf in requirements.txt Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> Signed-off-by: Dan Sun <dsun20@bloomberg.net> * Update kserve to 0.8.0.2 Signed-off-by: Dan Sun <dsun20@bloomberg.net> Co-authored-by: Andrews Arokiam <87992092+andyi2it@users.noreply.github.com>
wmfgerrit
pushed a commit
to wikimedia/operations-docker-images-production-images
that referenced
this pull request
Jul 25, 2022
As indicated in kserve/kserve#2201, we need to pin the `protobuf` package to a specific version, otherwise the code will not bootstrap correctly. Bug: T311982 Change-Id: Ie2a71c7677b00560a5891ef7051e660620bca4f5
alexagriffith
pushed a commit
to alexagriffith/kserve
that referenced
this pull request
Sep 19, 2022
Added a specific version for protobuf in requirements.txt Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andrews Arokiam andrews.arokiam@ideas2it.com
What this PR does / why we need it:
Added a specific version for protobuf in requirements.txt
Since a new version of protobuf is incompatible with some of the generated code, using a specific version, thats lower than
3.20.0
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #2200
Type of changes
Please delete options that are not relevant.
Feature/Issue validation/testing:
Special notes for your reviewer:
Release note: