Allow InferenceService url scheme to be configurable #2202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Winter <mark.winter@navercorp.com>
pvaneck
reviewed
Jun 3, 2022
There was a problem hiding this comment.
Thanks, @markwinter. I think this looks good and will be useful. Do you mind rebasing or merging master into your branch to get the latest e2e changes. Recently e2e tests were switched to github actions so want to ensure those run for this PR.
|
This is quite useful, thanks @markwinter ! /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markwinter, yuzisun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
alexagriffith
pushed a commit
to alexagriffith/kserve
that referenced
this pull request
Sep 19, 2022
Signed-off-by: Mark Winter <mark.winter@navercorp.com> Signed-off-by: alexagriffith <agriffith96@gmail.com>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This allows the URL scheme to be configurable in the
inferenceservice-configconfigmap.We have a wildcard certificate in the istio gateway to allow https traffic. We would like this to be reflected in the isvc url so users know they can use https.
Type of changes
Please delete options that are not relevant.
Feature/Issue validation/testing:
Please describe the tests that you ran to verify your changes and relevent result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
Test A
Test B
Logs
Checklist:
Release note: