Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python dep for kserve sdk #2216

Merged
merged 2 commits into from
Jun 5, 2022
Merged

Update python dep for kserve sdk #2216

merged 2 commits into from
Jun 5, 2022

Conversation

yuzisun
Copy link
Member

@yuzisun yuzisun commented Jun 4, 2022

What this PR does / why we need it:
Remove unnecessarily pinned dependency in kserve sdk requirement file

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2203 #1210

Type of changes
Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Feature/Issue validation/testing:

Please describe the tests that you ran to verify your changes and relevent result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A

  • Test B

  • Logs

Special notes for your reviewer:

  1. Add test matrix for python 3.7, 3.8, 3.9 and deprecate 3.6 which is EOL.

Checklist:

  • Have you added unit/e2e tests that prove your fix is effective or that this feature works?

Release note:

Release kserve sdk 0.9.0rc0

Signed-off-by: Dan Sun <dsun20@bloomberg.net>
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
Copy link
Member

@markwinter markwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I assume the test workflow files you removed was intentional.

@kserve-oss-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markwinter, yuzisun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yuzisun
Copy link
Member Author

yuzisun commented Jun 5, 2022

LGTM

I assume the test workflow files you removed was intentional.

yes, the kubeflow aws testing infra was deprecated and we have now migrated to use github action for e2e tests.

@markwinter
Copy link
Member

Ah okay thanks for explaining!

/lgtm

@yuzisun yuzisun merged commit df2ef69 into kserve:master Jun 5, 2022
@yuzisun yuzisun deleted the python_dep branch July 9, 2022 15:36
alexagriffith pushed a commit to alexagriffith/kserve that referenced this pull request Sep 19, 2022
* Remove pinned python deps

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

* Upgrade to 0.9.0rc0

Signed-off-by: Dan Sun <dsun20@bloomberg.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatible versions for google protos required by kserve and dependencies
3 participants