-
Notifications
You must be signed in to change notification settings - Fork 981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e enhancement changes #2237
Merged
Merged
e2e enhancement changes #2237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyi2it
force-pushed
the
workflow-changes
branch
7 times, most recently
from
June 10, 2022 10:25
b2338d0
to
df71042
Compare
yuzisun
reviewed
Jun 10, 2022
andyi2it
force-pushed
the
workflow-changes
branch
9 times, most recently
from
June 14, 2022 11:54
6ec394d
to
59774aa
Compare
/retest |
andyi2it
force-pushed
the
workflow-changes
branch
8 times, most recently
from
June 30, 2022 06:51
29359ba
to
a12d3f2
Compare
andyi2it
force-pushed
the
workflow-changes
branch
5 times, most recently
from
July 7, 2022 12:48
7f1d8d5
to
dad0e38
Compare
yuzisun
reviewed
Jul 13, 2022
yuzisun
reviewed
Jul 13, 2022
andyi2it
force-pushed
the
workflow-changes
branch
3 times, most recently
from
July 18, 2022 10:13
adf59c7
to
d5abba0
Compare
yuzisun
reviewed
Jul 19, 2022
Updated upload for all images Initial fast test run Updated slow tests Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
Skipping triton Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
removed parallel workers Added tabular explainer and pmml to test suite Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
Updated job names and bash parameter changes Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
Triton image is approximately 13.6 GB which will not work in github's default runner. So disabling it. Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
Removed inputs from composite actions as they were not used Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
andyi2it
force-pushed
the
workflow-changes
branch
from
July 19, 2022 19:16
a98ebed
to
6eaab96
Compare
Thanks @andyi2it! great work on this! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyi2it, yuzisun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
alexagriffith
pushed a commit
to alexagriffith/kserve
that referenced
this pull request
Sep 19, 2022
* Initial commit of e2e enhancements Updated upload for all images Initial fast test run Updated slow tests Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> * Split image builds as size limit was hit Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> * Split explainer into a separate job Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> * Skipping mms and tabular explainer for debugging Skipping triton Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> * Split transformer and mms removed parallel workers Added tabular explainer and pmml to test suite Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> * Enabled art explainer Updated job names and bash parameter changes Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> * Skipping triton as there images are bigger Triton image is approximately 13.6 GB which will not work in github's default runner. So disabling it. Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> * Trying out composite actions Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> * Updated description of composite actions Removed inputs from composite actions as they were not used Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> * Added marker to inference graph e2e test Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> Signed-off-by: alexagriffith <agriffith96@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Updates the CI/CD pipeline to run in parallel thereby reducing the run time.
Builds images locally and publishes them github artifcacts.
The published artifacts are used by other jobs in the workflow to run the tests in parallel.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #2209
Type of changes
Please delete options that are not relevant.
Feature/Issue validation/testing:
Special notes for your reviewer:
Checklist:
Release note: