Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e enhancement changes #2237

Merged
merged 11 commits into from
Jul 20, 2022
Merged

e2e enhancement changes #2237

merged 11 commits into from
Jul 20, 2022

Conversation

andyi2it
Copy link
Contributor

@andyi2it andyi2it commented Jun 9, 2022

What this PR does / why we need it:
Updates the CI/CD pipeline to run in parallel thereby reducing the run time.
Builds images locally and publishes them github artifcacts.
The published artifacts are used by other jobs in the workflow to run the tests in parallel.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2209

Type of changes
Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Feature/Issue validation/testing:

  • Logs

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Checklist:

  • Have you added unit/e2e tests that prove your fix is effective or that this feature works?

Release note:

NONE

@andyi2it andyi2it force-pushed the workflow-changes branch 9 times, most recently from 6ec394d to 59774aa Compare June 14, 2022 11:54
@andyi2it
Copy link
Contributor Author

/retest

@andyi2it andyi2it force-pushed the workflow-changes branch 8 times, most recently from 29359ba to a12d3f2 Compare June 30, 2022 06:51
@andyi2it andyi2it marked this pull request as ready for review June 30, 2022 10:01
@andyi2it andyi2it force-pushed the workflow-changes branch 5 times, most recently from 7f1d8d5 to dad0e38 Compare July 7, 2022 12:48
@andyi2it andyi2it force-pushed the workflow-changes branch 3 times, most recently from adf59c7 to d5abba0 Compare July 18, 2022 10:13
.github/actions/minikube-setup/action.yml Outdated Show resolved Hide resolved
.github/actions/minikube-setup/action.yml Outdated Show resolved Hide resolved
.github/actions/base-download/action.yml Outdated Show resolved Hide resolved
.github/actions/base-download/action.yml Outdated Show resolved Hide resolved
Updated upload for all images

Initial fast test run

Updated slow tests

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
Skipping triton

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
removed parallel workers

Added tabular explainer and pmml to test suite

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
Updated job names and bash parameter changes

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
Triton image is approximately 13.6 GB which will not work in
github's default runner.
So disabling it.

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
Removed inputs from composite actions as they were not used

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
@yuzisun
Copy link
Member

yuzisun commented Jul 20, 2022

Thanks @andyi2it! great work on this!
/lgtm
/approve

@kserve-oss-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyi2it, yuzisun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yuzisun yuzisun merged commit 8bc67d7 into kserve:master Jul 20, 2022
alexagriffith pushed a commit to alexagriffith/kserve that referenced this pull request Sep 19, 2022
* Initial commit of e2e enhancements

Updated upload for all images

Initial fast test run

Updated slow tests

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>

* Split image builds as size limit was hit

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>

* Split explainer into a separate job

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>

* Skipping mms and tabular explainer for debugging

Skipping triton

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>

* Split transformer and mms

removed parallel workers

Added tabular explainer and pmml to test suite

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>

* Enabled art explainer

Updated job names and bash parameter changes

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>

* Skipping triton as there images are bigger

Triton image is approximately 13.6 GB which will not work in
github's default runner. So disabling it.

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>

* Trying out composite actions

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>

* Updated description of composite actions
Removed inputs from composite actions as they were not used

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>

* Added marker to inference graph e2e test

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
Signed-off-by: alexagriffith <agriffith96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enhance github action based e2e test
3 participants