Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Kserve dependencies conflicts with KFP #2295

Merged
merged 1 commit into from
Jul 1, 2022

Conversation

safoinme
Copy link
Contributor

@safoinme safoinme commented Jun 30, 2022

What this PR does / why we need it:
This PR changes the Kubernetes and google-cloud-storage dependencies versions to an older version. This will resolve the conflicts when trying to install Kserve SDK with Kubeflow SDK since this last one still using old versions.

fixes #2277

Type of changes
Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Checklist:

  • Have you added unit/e2e tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

Release note:

Support old versions of dependencies to resolve conflicts with KFP SDK

@safoinme
Copy link
Contributor Author

safoinme commented Jun 30, 2022

/cc @markwinter
/cc @yuzisun
/uncc @pugangxa
/uncc @pvaneck

@markwinter
Copy link
Member

markwinter commented Jun 30, 2022

@safoinme
Thanks for this.

You will need to sign off your commit to pass the DCO check. There are some instructions here
https://github.com/kserve/kserve/pull/2295/checks?check_run_id=7129383180

Make sure you have set your git config user.name and git config user.email then do the following to sign off previous commit:

  • git rebase HEAD~1 --signoff
  • git push --force-with-lease origin fix_max_batch_latency

…google-cloud-storage

Signed-off-by: Safoine El Khabich <safoine.ext@zenml.io>
@safoinme
Copy link
Contributor Author

@markwinter it's done! thanks for the instructions

@markwinter
Copy link
Member

/lgtm

@markwinter
Copy link
Member

/approve

1 similar comment
@yuzisun
Copy link
Member

yuzisun commented Jul 1, 2022

/approve

@kserve-oss-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markwinter, safoinme, yuzisun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kserve-oss-bot kserve-oss-bot merged commit c75e526 into kserve:master Jul 1, 2022
alexagriffith pushed a commit to alexagriffith/kserve that referenced this pull request Sep 19, 2022
…google-cloud-storage (kserve#2295)

Signed-off-by: Safoine El Khabich <safoine.ext@zenml.io>
Signed-off-by: alexagriffith <agriffith96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kserve dependencies conflicts with KFP - Tensorflow - etc...
4 participants